From: Steven Rostedt <rostedt@goodmis.org>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Jason Baron <jbaron@akamai.com>
Subject: Re: [PATCH 4/4] x86/jump-label: Show where and what was wrong on errors
Date: Wed, 07 Aug 2013 13:33:06 -0400 [thread overview]
Message-ID: <1375896786.6848.14.camel@gandalf.local.home> (raw)
In-Reply-To: <20130807172044.GC18272@pd.tnic>
On Wed, 2013-08-07 at 19:20 +0200, Borislav Petkov wrote:
>
> > +static void bug_at(unsigned char *ip, int line)
> > +{
> > + /*
> > + * The location is not an op that we were expecting.
> > + * Something went wrong. Crash the box, as something could be
> > + * corrupting the kernel.
> > + */
> > + pr_warning("Unexpected op at %pS [%p] (%02x %02x %02x %02x %02x) %s:%d\n",
> > + ip, ip, ip[0], ip[1], ip[2], ip[3], ip[4], __FILE__, line);
> > + BUG();
>
> Why not simply
>
> panic("Unexpected...")
>
> ?
Because the patch replaced BUG().
>
> Besides, BUG can be disabled in CONFIG_EXPERT.
>
Right, and this code keeps the same logic as it was before. If it was
disabled by CONFIG_EXPERT, it stays disabled, but at least you get to
see a warning that your kernel may be corrupt now :-)
-- Steve
next prev parent reply other threads:[~2013-08-07 17:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 16:49 [PATCH 0/4] [GIT PULL][3.12] x86/jump-label: Clean ups and safety checks Steven Rostedt
2013-08-07 16:49 ` [PATCH 1/4] x86/jump-label: Use best default nops for inital jump label calls Steven Rostedt
2013-08-07 16:49 ` [PATCH 2/4] x86/jump-label: Do not bother updating nops if they are correct Steven Rostedt
2013-08-07 16:49 ` [PATCH 3/4] x86/jump-label: Add safety checks to jump label conversions Steven Rostedt
2013-08-07 16:49 ` [PATCH 4/4] x86/jump-label: Show where and what was wrong on errors Steven Rostedt
2013-08-07 17:20 ` Borislav Petkov
2013-08-07 17:33 ` Steven Rostedt [this message]
2013-08-07 17:37 ` Borislav Petkov
2013-08-07 17:46 ` Steven Rostedt
2013-08-07 17:51 ` H. Peter Anvin
2013-08-07 18:41 ` Borislav Petkov
2013-08-07 18:45 ` H. Peter Anvin
2013-08-12 14:31 ` Peter Zijlstra
2013-08-12 14:32 ` H. Peter Anvin
2013-08-12 15:57 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375896786.6848.14.camel@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jbaron@akamai.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.