From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <1375948365.2219.21.camel@sauron.fi.intel.com> Subject: Re: [PATCH 03/20] ARM: pxa: ssp: add shortcut for &pdev->dev From: Artem Bityutskiy To: Brian Norris Date: Thu, 08 Aug 2013 10:52:45 +0300 In-Reply-To: <20130808073253.GA17106@norris.computersforpeace.net> References: <1375889649-14638-1-git-send-email-zonque@gmail.com> <1375889649-14638-4-git-send-email-zonque@gmail.com> <20130808073253.GA17106@norris.computersforpeace.net> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: mark.rutland@arm.com, s.neumann@raumfeld.com, linux-mtd@lists.infradead.org, haojian.zhuang@linaro.org, cxie4@marvell.com, lars@metafoo.de, nico@linaro.org, vinod.koul@intel.com, marek.vasut@gmail.com, ezequiel.garcia@free-electrons.com, rmk+kernel@arm.linux.org.uk, g.liakhovetski@gmx.de, devicetree@vger.kernel.org, samuel@sortiz.org, arnd@arndb.de, broonie@kernel.org, mika.westerberg@linux.intel.com, linux-arm-kernel@lists.infradead.org, thomas.petazzoni@free-electrons.com, eric.y.miao@gmail.com, gregkh@linuxfoundation.org, Daniel Mack , sachin.kamat@linaro.org, kernel@pengutronix.de, djbw@fb.com, davem@davemloft.net Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2013-08-08 at 00:32 -0700, Brian Norris wrote: > On Wed, Aug 07, 2013 at 05:33:52PM +0200, Daniel Mack wrote: > > No functional change, just a cosmetic cleanup. > > > > Signed-off-by: Daniel Mack > > --- > > --- a/arch/arm/plat-pxa/ssp.c > > +++ b/arch/arm/plat-pxa/ssp.c > > @@ -77,16 +77,17 @@ static int pxa_ssp_probe(struct platform_device *pdev) > > const struct platform_device_id *id = platform_get_device_id(pdev); > > struct resource *res; > > struct ssp_device *ssp; > > + struct device *dev = &pdev->dev; > > int ret = 0; > > > > ssp = kzalloc(sizeof(struct ssp_device), GFP_KERNEL); > > if (ssp == NULL) { > > - dev_err(&pdev->dev, "failed to allocate memory"); > > + dev_err(dev, "failed to allocate memory"); > > Two options here: either remove the message entirely (I believe kzalloc > will complain loudly if the allocation fails) or at least add a newline > at the end of it! I think only to former is the right option. -- Best Regards, Artem Bityutskiy From mboxrd@z Thu Jan 1 00:00:00 1970 From: dedekind1@gmail.com (Artem Bityutskiy) Date: Thu, 08 Aug 2013 10:52:45 +0300 Subject: [PATCH 03/20] ARM: pxa: ssp: add shortcut for &pdev->dev In-Reply-To: <20130808073253.GA17106@norris.computersforpeace.net> References: <1375889649-14638-1-git-send-email-zonque@gmail.com> <1375889649-14638-4-git-send-email-zonque@gmail.com> <20130808073253.GA17106@norris.computersforpeace.net> Message-ID: <1375948365.2219.21.camel@sauron.fi.intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 2013-08-08 at 00:32 -0700, Brian Norris wrote: > On Wed, Aug 07, 2013 at 05:33:52PM +0200, Daniel Mack wrote: > > No functional change, just a cosmetic cleanup. > > > > Signed-off-by: Daniel Mack > > --- > > --- a/arch/arm/plat-pxa/ssp.c > > +++ b/arch/arm/plat-pxa/ssp.c > > @@ -77,16 +77,17 @@ static int pxa_ssp_probe(struct platform_device *pdev) > > const struct platform_device_id *id = platform_get_device_id(pdev); > > struct resource *res; > > struct ssp_device *ssp; > > + struct device *dev = &pdev->dev; > > int ret = 0; > > > > ssp = kzalloc(sizeof(struct ssp_device), GFP_KERNEL); > > if (ssp == NULL) { > > - dev_err(&pdev->dev, "failed to allocate memory"); > > + dev_err(dev, "failed to allocate memory"); > > Two options here: either remove the message entirely (I believe kzalloc > will complain loudly if the allocation fails) or at least add a newline > at the end of it! I think only to former is the right option. -- Best Regards, Artem Bityutskiy