* [PATCH V2] ARM: dts: Add RTC DT node to Exynos5420 SoC
@ 2013-08-12 11:51 Vikas Sajjan
2013-08-14 5:05 ` Vikas Sajjan
2013-08-14 5:44 ` Kukjin Kim
0 siblings, 2 replies; 4+ messages in thread
From: Vikas Sajjan @ 2013-08-12 11:51 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: kgene.kim, patches, linaro-kernel
Adds RTC DT node to Exynos5420 SoC.
Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
changes since v1:
- made DT node status as "okay" in the dtsi file itself.
---
arch/arm/boot/dts/exynos5.dtsi | 2 +-
arch/arm/boot/dts/exynos5250.dtsi | 3 ++-
arch/arm/boot/dts/exynos5420.dtsi | 7 +++++++
3 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
index f65e124..4a8e223 100644
--- a/arch/arm/boot/dts/exynos5.dtsi
+++ b/arch/arm/boot/dts/exynos5.dtsi
@@ -95,7 +95,7 @@
interrupts = <0 54 0>;
};
- rtc {
+ rtc@101E0000 {
compatible = "samsung,s3c6410-rtc";
reg = <0x101E0000 0x100>;
interrupts = <0 43 0>, <0 44 0>;
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 88589b7..c82137b 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -178,9 +178,10 @@
samsung,power-domain = <&pd_mfc>;
};
- rtc {
+ rtc@101E0000 {
clocks = <&clock 337>;
clock-names = "rtc";
+ status = "okay";
};
tmu@10060000 {
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 9e90d1e..8f1bb08 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -145,4 +145,11 @@
clocks = <&clock 260>, <&clock 131>;
clock-names = "uart", "clk_uart_baud0";
};
+
+ rtc@101E0000 {
+ clocks = <&clock 317>;
+ clock-names = "rtc";
+ status = "okay";
+ };
+
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH V2] ARM: dts: Add RTC DT node to Exynos5420 SoC
2013-08-12 11:51 [PATCH V2] ARM: dts: Add RTC DT node to Exynos5420 SoC Vikas Sajjan
@ 2013-08-14 5:05 ` Vikas Sajjan
2013-08-14 5:44 ` Kukjin Kim
1 sibling, 0 replies; 4+ messages in thread
From: Vikas Sajjan @ 2013-08-14 5:05 UTC (permalink / raw)
To: Kukjin Kim; +Cc: linux-samsung-soc, patches, linaro-kernel
Hi Kukjin,
On Mon, Aug 12, 2013 at 5:21 PM, Vikas Sajjan <vikas.sajjan@linaro.org> wrote:
> Adds RTC DT node to Exynos5420 SoC.
>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> ---
> changes since v1:
> - made DT node status as "okay" in the dtsi file itself.
> ---
> arch/arm/boot/dts/exynos5.dtsi | 2 +-
> arch/arm/boot/dts/exynos5250.dtsi | 3 ++-
> arch/arm/boot/dts/exynos5420.dtsi | 7 +++++++
> 3 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
> index f65e124..4a8e223 100644
> --- a/arch/arm/boot/dts/exynos5.dtsi
> +++ b/arch/arm/boot/dts/exynos5.dtsi
> @@ -95,7 +95,7 @@
> interrupts = <0 54 0>;
> };
>
> - rtc {
> + rtc@101E0000 {
> compatible = "samsung,s3c6410-rtc";
> reg = <0x101E0000 0x100>;
> interrupts = <0 43 0>, <0 44 0>;
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 88589b7..c82137b 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -178,9 +178,10 @@
> samsung,power-domain = <&pd_mfc>;
> };
>
> - rtc {
> + rtc@101E0000 {
> clocks = <&clock 337>;
> clock-names = "rtc";
> + status = "okay";
> };
>
> tmu@10060000 {
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index 9e90d1e..8f1bb08 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -145,4 +145,11 @@
> clocks = <&clock 260>, <&clock 131>;
> clock-names = "uart", "clk_uart_baud0";
> };
> +
> + rtc@101E0000 {
> + clocks = <&clock 317>;
> + clock-names = "rtc";
> + status = "okay";
> + };
> +
> };
Can you apply this patch.
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH V2] ARM: dts: Add RTC DT node to Exynos5420 SoC
2013-08-12 11:51 [PATCH V2] ARM: dts: Add RTC DT node to Exynos5420 SoC Vikas Sajjan
2013-08-14 5:05 ` Vikas Sajjan
@ 2013-08-14 5:44 ` Kukjin Kim
2013-08-14 6:03 ` Vikas Sajjan
1 sibling, 1 reply; 4+ messages in thread
From: Kukjin Kim @ 2013-08-14 5:44 UTC (permalink / raw)
To: 'Vikas Sajjan', linux-samsung-soc; +Cc: patches, linaro-kernel
Vikas Sajjan wrote:
>
> Adds RTC DT node to Exynos5420 SoC.
>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> ---
> changes since v1:
> - made DT node status as "okay" in the dtsi file itself.
> ---
> arch/arm/boot/dts/exynos5.dtsi | 2 +-
> arch/arm/boot/dts/exynos5250.dtsi | 3 ++-
> arch/arm/boot/dts/exynos5420.dtsi | 7 +++++++
> 3 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5.dtsi
> b/arch/arm/boot/dts/exynos5.dtsi
> index f65e124..4a8e223 100644
> --- a/arch/arm/boot/dts/exynos5.dtsi
> +++ b/arch/arm/boot/dts/exynos5.dtsi
> @@ -95,7 +95,7 @@
> interrupts = <0 54 0>;
> };
>
> - rtc {
> + rtc@101E0000 {
> compatible = "samsung,s3c6410-rtc";
> reg = <0x101E0000 0x100>;
> interrupts = <0 43 0>, <0 44 0>;
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index 88589b7..c82137b 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -178,9 +178,10 @@
> samsung,power-domain = <&pd_mfc>;
> };
>
> - rtc {
> + rtc@101E0000 {
> clocks = <&clock 337>;
> clock-names = "rtc";
> + status = "okay";
Well, according to the subject, 'add rtc dt node to exynos5420', this should
be handled separately if required.
> };
>
> tmu@10060000 {
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> b/arch/arm/boot/dts/exynos5420.dtsi
> index 9e90d1e..8f1bb08 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -145,4 +145,11 @@
> clocks = <&clock 260>, <&clock 131>;
> clock-names = "uart", "clk_uart_baud0";
> };
> +
> + rtc@101E0000 {
Please put in the address order or alphabetical.
> + clocks = <&clock 317>;
> + clock-names = "rtc";
> + status = "okay";
> + };
> +
No need last empty line.
- Kukjin
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH V2] ARM: dts: Add RTC DT node to Exynos5420 SoC
2013-08-14 5:44 ` Kukjin Kim
@ 2013-08-14 6:03 ` Vikas Sajjan
0 siblings, 0 replies; 4+ messages in thread
From: Vikas Sajjan @ 2013-08-14 6:03 UTC (permalink / raw)
To: Kukjin Kim; +Cc: Vikas Sajjan, linux-samsung-soc, patches, linaro-kernel
Hi Kukjin,
On Wed, Aug 14, 2013 at 11:14 AM, Kukjin Kim <kgene@kernel.org> wrote:
> Vikas Sajjan wrote:
>>
>> Adds RTC DT node to Exynos5420 SoC.
>>
>> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
>> ---
>> changes since v1:
>> - made DT node status as "okay" in the dtsi file itself.
>> ---
>> arch/arm/boot/dts/exynos5.dtsi | 2 +-
>> arch/arm/boot/dts/exynos5250.dtsi | 3 ++-
>> arch/arm/boot/dts/exynos5420.dtsi | 7 +++++++
>> 3 files changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5.dtsi
>> b/arch/arm/boot/dts/exynos5.dtsi
>> index f65e124..4a8e223 100644
>> --- a/arch/arm/boot/dts/exynos5.dtsi
>> +++ b/arch/arm/boot/dts/exynos5.dtsi
>> @@ -95,7 +95,7 @@
>> interrupts = <0 54 0>;
>> };
>>
>> - rtc {
>> + rtc@101E0000 {
>> compatible = "samsung,s3c6410-rtc";
>> reg = <0x101E0000 0x100>;
>> interrupts = <0 43 0>, <0 44 0>;
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>> b/arch/arm/boot/dts/exynos5250.dtsi
>> index 88589b7..c82137b 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -178,9 +178,10 @@
>> samsung,power-domain = <&pd_mfc>;
>> };
>>
>> - rtc {
>> + rtc@101E0000 {
>> clocks = <&clock 337>;
>> clock-names = "rtc";
>> + status = "okay";
>
> Well, according to the subject, 'add rtc dt node to exynos5420', this should
> be handled separately if required.
>
So, you want me to spit this 5250 modification to a separate patch
OR
Modify the subject line to match the changes.
>> };
>>
>> tmu@10060000 {
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
>> b/arch/arm/boot/dts/exynos5420.dtsi
>> index 9e90d1e..8f1bb08 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -145,4 +145,11 @@
>> clocks = <&clock 260>, <&clock 131>;
>> clock-names = "uart", "clk_uart_baud0";
>> };
>> +
>> + rtc@101E0000 {
>
> Please put in the address order or alphabetical.
>
Sure will do.
>> + clocks = <&clock 317>;
>> + clock-names = "rtc";
>> + status = "okay";
>> + };
>> +
>
> No need last empty line.
OK.
>
> - Kukjin
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-14 6:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-12 11:51 [PATCH V2] ARM: dts: Add RTC DT node to Exynos5420 SoC Vikas Sajjan
2013-08-14 5:05 ` Vikas Sajjan
2013-08-14 5:44 ` Kukjin Kim
2013-08-14 6:03 ` Vikas Sajjan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.