All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ijc@hellion.org.uk>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Mike <debian@good-with-numbers.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH] hotplug/Linux: update to new ip command syntax.
Date: Mon, 19 Aug 2013 18:01:12 +0100	[thread overview]
Message-ID: <1376931672.9708.91.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <21010.19305.453261.252793@mariner.uk.xensource.com>

On Mon, 2013-08-19 at 17:44 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH] hotplug/Linux: update to new ip command syntax."):
> > From: Mike <debian@good-with-numbers.com>
> > 
> > This is Debian bug #705659. http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=705659
> > 
> > Mike provided the initial patch to tools/hotplug/Linux/xen-network-common.sh
> > and I extended it to catch some cases in vif-* too.
> > 
> > Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> > Cc: Mike <debian@good-with-numbers.com>
> 
> Do we know whether this new syntax is backwards-compatible ?

Good question. Squeeze's ip(8) doesn't mention dev for "ip link show" in
the synopsis by virtue of not defining DEVICE anywhere but it does show
the use of dev later on and the tool accepts it. Likewise for "ip link
set". Given this, as Mike says, makes it impossible to name a device
"dev" it seems likely to be a documentation bug.

"ip addr flush" is correctly documented as needing the dev (by saying
"dev STRING" and not "DEVICE" , I didn't try without but I assume it
works since our scripts do that right now.

I wasn't easily able to come up with an older machine.

Ian.

  reply	other threads:[~2013-08-19 17:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-16 14:31 [PATCH] hotplug/Linux: update to new ip command syntax Ian Campbell
2013-08-16 19:30 ` Mike
2013-08-19 16:44 ` Ian Jackson
2013-08-19 17:01   ` Ian Campbell [this message]
2013-11-19 12:23     ` Ian Campbell
2013-11-20 14:37       ` Ian Jackson
2013-11-20 14:53         ` Ian Campbell
2013-11-20 18:50           ` George Dunlap
2013-11-21 10:01             ` Ian Campbell
2013-11-21 15:08               ` George Dunlap
2013-11-21 18:44                 ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376931672.9708.91.camel@dagon.hellion.org.uk \
    --to=ijc@hellion.org.uk \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=debian@good-with-numbers.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.