All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/4] mtd: nand: omap: enable BCH ECC scheme using ELM for generic platform
Date: Thu, 22 Aug 2013 17:25:23 -0500	[thread overview]
Message-ID: <1377210323.20722.26.camel@snotra.buserror.net> (raw)
In-Reply-To: <1376461015-29007-2-git-send-email-pekon@ti.com>

On Wed, 2013-08-14 at 11:46 +0530, Pekon Gupta wrote:
> BCH8_ECC scheme implemented in omap_gpmc.c driver has following two favours
> +-----------------------------------+-----------------+-----------------+
> |ECC Scheme                         | ECC Calculation | Error Detection |
> +-----------------------------------+-----------------+-----------------+
> |OMAP_ECC_BCH8_CODE_HW              |GPMC             |ELM H/W engine   |
> |OMAP_ECC_BCH8_CODE_HW_DETECTION_SW |GPMC             |S/W BCH library  |
> +-----------------------------------+-----------------+-----------------+
> 
> Current implementation enables of BCH8_CODE_HW only for AM33xx SoC family.
> (using CONFIG_AM33XX). However, other SoC families (like TI81xx) also have
> ELM hardware module, and can support ECC error detection using ELM.
> 
> This patch
> - replaces CONFIG_AM33xx define with
> 	CONFIG_NAND_OMAP_ECC_BCH8_CODE_HW
>   so that all device families having required h/w capability can use ELM for
>   error detection in ECC_BCHx schemes.
> 
> - replaces CONFIG_NAND_OMAP_BCH8 with
> 	CONFIG_NAND_OMAP_ECC_BCH8_CODE_HW_DETECTION_SW && CONFIG_BCH
>   and separates out code for above mentioned BCH8_ECC implementations so that
>   driver can be build independently using anyone of them.
>   CONFIG_BCH is used to enable software BCH library in lib/bch.c
> 
> Signed-off-by: Pekon Gupta <pekon@ti.com>
> ---
>  doc/README.nand              |  20 +++++++
>  drivers/mtd/nand/omap_gpmc.c | 128 ++++++++++++++++++++++++-------------------
>  include/configs/am335x_evm.h |   1 +
>  include/configs/ti814x_evm.h |   2 +-
>  include/configs/tricorder.h  |   2 +-
>  5 files changed, 96 insertions(+), 57 deletions(-)

The ti814x_evm.h changes do not apply.  What tree is this against?

Can someone familiar with the OMAP driver review this patchset?

-Scott

  reply	other threads:[~2013-08-22 22:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-14  6:16 [U-Boot] [PATCH v2 0/4] mtd: nand: omap: optimize and clean-up of OMAP NAND driver Pekon Gupta
2013-08-14  6:16 ` [U-Boot] [PATCH v2 1/4] mtd: nand: omap: enable BCH ECC scheme using ELM for generic platform Pekon Gupta
2013-08-22 22:25   ` Scott Wood [this message]
2013-08-23 12:43     ` Tom Rini
2013-08-23 17:55       ` Scott Wood
2013-08-14  6:16 ` [U-Boot] [PATCH v2 2/4] mtd: nand: omap: optimize chip->ecc.hwctl() for H/W ECC schemes Pekon Gupta
2013-08-14  6:16 ` [U-Boot] [PATCH v2 3/4] mtd: nand: omap: optimize chip->ecc.calculate() " Pekon Gupta
2013-08-14  6:16 ` [U-Boot] [PATCH v2 4/4] mtd: nand: omap: optimized chip->ecc.correct() " Pekon Gupta
2013-08-23 22:19 ` [U-Boot] [PATCH v2 0/4] mtd: nand: omap: optimize and clean-up of OMAP NAND driver Tom Rini
2013-08-24  4:01   ` Gupta, Pekon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377210323.20722.26.camel@snotra.buserror.net \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.