From: "Graham Williams" <gwilli@broadcom.com>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Felipe Balbi" <balbi@ti.com>
Cc: "Graham Williams" <gwilli@broadcom.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] usb: acm gadget: Null termintate strings table
Date: Wed, 28 Aug 2013 16:36:14 -0700 [thread overview]
Message-ID: <1377732974-10073-1-git-send-email-gwilli@broadcom.com> (raw)
The gadget strings table should be null terminated.
usb_gadget_get_string() loops through the table
expecting a null at the end of the list.
Signed-off-by: Graham Williams <gwilli@broadcom.com>
---
drivers/usb/gadget/f_acm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/f_acm.c b/drivers/usb/gadget/f_acm.c
index 4b7e33e..ab1065a 100644
--- a/drivers/usb/gadget/f_acm.c
+++ b/drivers/usb/gadget/f_acm.c
@@ -285,6 +285,7 @@ static struct usb_string acm_string_defs[] = {
[ACM_CTRL_IDX].s = "CDC Abstract Control Model (ACM)",
[ACM_DATA_IDX].s = "CDC ACM Data",
[ACM_IAD_IDX ].s = "CDC Serial",
+ { } /* end of list */
};
static struct usb_gadget_strings acm_string_table = {
--
1.8.0.1
next reply other threads:[~2013-08-28 23:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 23:36 Graham Williams [this message]
2013-08-30 18:11 ` [PATCH] usb: acm gadget: Null termintate strings table Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2013-08-23 23:19 Graham Williams
2013-08-23 23:36 ` Greg KH
2013-08-23 17:51 Graham Williams
2013-08-23 18:21 ` Greg KH
2013-08-23 17:43 Graham Williams
2013-08-23 17:49 ` Greg KH
2013-08-22 19:10 Graham Williams
2013-08-27 20:03 ` Felipe Balbi
2013-08-20 15:17 Graham Williams
2013-08-23 17:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377732974-10073-1-git-send-email-gwilli@broadcom.com \
--to=gwilli@broadcom.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.