From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] libvhd: use UTC for VHD timestamp
Date: Tue, 3 Sep 2013 17:32:05 +0100
Message-ID: <1378225925.17510.25.camel@kazak.uk.xensource.com>
References: <1377868040-13668-1-git-send-email-wei.liu2@citrix.com>
	<20130830155013.GY15729@zion.uk.xensource.com>
	<21024.49080.965845.357206@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21024.49080.965845.357206@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org, Wei Liu <wei.liu2@citrix.com>, Andrei Lifchits <andrei.lifchits@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2013-08-30 at 16:52 +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH] libvhd: use UTC for VHD timestamp"):
> > Update commit message.
> 
> Thanks.
> 
> > From: Wei Liu <wei.liu2@citrix.com>
> > Date: Fri, 30 Aug 2013 12:33:33 +0100
> > Subject: [PATCH] libvhd: use UTC for VHD timestamp
> > 
> > [ported from xapi-project/blktap a79ac2c05f9 ("XOP-289: use UTC for VHD
> > timestamps")]
> > 
> > Currently, the local timezone is factored into VHD timestamps due to the
> > use of mktime(). This breaks "vhd-util check" for VHDs created in one
> > timezone and then moved westward, which results in "primary footer
> > invalid: creation time in future" errors.
> 
> The existing code here is, erm, "surprising".  Thanks for your
> attention to it!
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Applied with the commit message formatted as:

    libvhd: use UTC for VHD timestamp
    
    [ported from xapi-project/blktap a79ac2c05f9 ("XOP-289: use UTC for VHD
    timestamps")]
    
    Currently, the local timezone is factored into VHD timestamps due to the
    use of mktime(). This breaks "vhd-util check" for VHDs created in one
    timezone and then moved westward, which results in "primary footer
    invalid: creation time in future" errors.
    
    Signed-off-by: Andrei Lifchits <andrei.lifchits@citrix.com>
    
    Andrei no longer works for Citrix but Germano Percossi (ex-colleague of
    Andrei) contacted Andrei and confirmed that
      1) this work was written on Citrix time,
      2) it is OK to have Andrei's SoB.
    
    Remove unused variable "tm".
    
    Signed-off-by: Germano Percossi <germano.percossi@citrix.com>
    Signed-off-by: Wei Liu <wei.liu2@citrix.com>
    Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>