From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 13/28] libxl: only free cputopology if it
 was allocated in libxl_{cpu, node}map_to_{node, cpu}map
Date: Wed, 18 Sep 2013 10:59:27 +0200
Message-ID: <1379494767.18543.77.camel@Abyss>
References: <1379475484-25993-1-git-send-email-mattjd@gmail.com>
	<1379475484-25993-14-git-send-email-mattjd@gmail.com>
	<1379492310.18543.54.camel@Abyss>
	<CA+nUz_+brXRVfK=Qo8GECGRu+GQJf0vt+MGX1XZ1WcitB8Tb5g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3396964562488717321=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CA+nUz_+brXRVfK=Qo8GECGRu+GQJf0vt+MGX1XZ1WcitB8Tb5g@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Matthew Daley <mattjd@gmail.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

--===============3396964562488717321==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-Bt7gafLECjDdR+STB1wA"

--=-Bt7gafLECjDdR+STB1wA
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On mer, 2013-09-18 at 20:50 +1200, Matthew Daley wrote:
> On Wed, Sep 18, 2013 at 8:18 PM, Dario Faggioli
> <dario.faggioli@citrix.com> wrote:
> > On mer, 2013-09-18 at 15:37 +1200, Matthew Daley wrote:
> >> Coverity-ID: 1055294
> >> Coverity-ID: 1055295
> >>
> > Ok, forgive my coverity ignorance and sorry if I should know this
> > already, but I do I use these IDs to get some useful information?
>=20
> You can if you have access to the scan results. I've just been adding
> them to the commit messages as that's what I've seen done in other
> projects (and other people's Coverity-related Xen patches here). It
> also helps in situations like these.
>=20
Ok, fine, just curious, but no big deal at all. Basically, I wanted to
put some of those 'detailed info' in the changelog of the patch we're
talking about below, but again, no big deal, I'll (if I get there first)
just put the IDs there.

> > Still, I think I'd like this fixed by doing something like this:
> >
> >  653     int nr_cpus =3D 0, i, rc =3D 0;
> >
> > rather than with what this patch does, for the same reasons already
> > explained in the other e-mails.
> >
> > I'm up for sending such patch myself, but that will be in a while, as
> > right now I'm away from my workstation.
> >
> > Is that fine with you?
>=20
> Sure, or I can do it myself soon (ie. as a reply to this, or in the
> next batch of patches). There's no rush (AFAIK ;) )
>=20
Indeed. Whoever gets to it first will do and send the patch. :-) If it
is you, please, do Cc me (I'll do the same).

Thanks and Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-Bt7gafLECjDdR+STB1wA
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)

iEYEABECAAYFAlI5a28ACgkQk4XaBE3IOsTxNACfeUsbBWDmb3ifcrppkKo1oqOK
LF0AnRXvGY6UOU042Z5YyCG2hESb2wMt
=I3uy
-----END PGP SIGNATURE-----

--=-Bt7gafLECjDdR+STB1wA--


--===============3396964562488717321==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============3396964562488717321==--