From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 12/28] libxl: only free cputopology if it
 was allocated in libxl__get_numa_candidate
Date: Wed, 18 Sep 2013 11:10:50 +0200
Message-ID: <1379495450.18543.84.camel@Abyss>
References: <1379475484-25993-1-git-send-email-mattjd@gmail.com>
	<1379475484-25993-13-git-send-email-mattjd@gmail.com>
	<1379491026.18543.41.camel@Abyss>
	<CA+nUz_+XuLy=tnWyfpcbQa3PZv3bsL-5s=EtNWsq9s6xOUgxGg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7502062931098435261=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CA+nUz_+XuLy=tnWyfpcbQa3PZv3bsL-5s=EtNWsq9s6xOUgxGg@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Matthew Daley <mattjd@gmail.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============7502062931098435261==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-82nUmMkt5jgjfJxl0u79"

--=-82nUmMkt5jgjfJxl0u79
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On mer, 2013-09-18 at 20:42 +1200, Matthew Daley wrote:
> On Wed, Sep 18, 2013 at 7:57 PM, Dario Faggioli
>
> > Also, if something like that would be necessary, why doing it only for
> > tinfo and not for ninfo as well? I'm not that into coverity, but I don'=
t
> > think I see why it treats the two of them differently... :-O
>=20
> Not sure. Probably because if ninfo =3D=3D NULL, we return directly out o=
f
> the function instead of goto-ing the cleanup.
>=20
Right, which, now that I've seen it, calls for a patch making it go
through cleanup too! :-P

Anyway, for libxl_cputopology_list_free() (and also for
libxl_numainfo_list_free() if I really decide to patch it to make it
more "libxl style"), especially considering that something similar to
this happens in other places (as we're seeing in 13/28), is there
anything we can do for preventing this to come up again in future scans?

Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-82nUmMkt5jgjfJxl0u79
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)

iEYEABECAAYFAlI5bhoACgkQk4XaBE3IOsRPswCdFxdyFISxOvHU9gEw5vbFRvC3
yhQAn17ZVgN9u81bYTwPsvBQcyQNIK4+
=n2nw
-----END PGP SIGNATURE-----

--=-82nUmMkt5jgjfJxl0u79--


--===============7502062931098435261==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============7502062931098435261==--