All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86: Add quirk to make Dell C6100 use reboot=pci.
@ 2013-09-20 22:59 Vinson Lee
  2013-09-23 13:37 ` [tip:x86/urgent] x86/reboot: Add quirk to make Dell C6100 use reboot=pci automatically tip-bot for Masoud Sharbiani
  0 siblings, 1 reply; 3+ messages in thread
From: Vinson Lee @ 2013-09-20 22:59 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, Andrew Morton,
	Robin Holt, Russell King, Guan Xuetao, linux-kernel
  Cc: Vinson Lee, Masoud Sharbiani, stable, Vinson Lee

From: Masoud Sharbiani <msharbiani@twitter.com>

Dell PowerEdge C6100 machines fail to completely reboot about 20% of the
time.

Signed-off-by: Masoud Sharbiani <msharbiani@twitter.com>
Cc: stable@vger.kernel.org
Signed-off-by: Vinson Lee <vlee@twitter.com>
---
 arch/x86/kernel/reboot.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index df1b604..d139208 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -479,6 +479,22 @@ static struct dmi_system_id __initdata pci_reboot_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Precision M6600"),
 		},
 	},
+	{	/* Handle problems with rebooting on the Dell PowerEdge C6100. */
+		.callback = set_pci_reboot,
+		.ident = "Dell PowerEdge C6100",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "C6100"),
+		},
+	},
+	{	/* Some C6100 machines were shipped with vendor being 'Dell'. */
+		.callback = set_pci_reboot,
+		.ident = "Dell PowerEdge C6100",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "C6100"),
+		},
+	},
 	{ }
 };
 
-- 
1.8.1.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip:x86/urgent] x86/reboot: Add quirk to make Dell C6100 use reboot=pci automatically
  2013-09-20 22:59 [PATCH] x86: Add quirk to make Dell C6100 use reboot=pci Vinson Lee
@ 2013-09-23 13:37 ` tip-bot for Masoud Sharbiani
  2013-09-24 22:55   ` H. Peter Anvin
  0 siblings, 1 reply; 3+ messages in thread
From: tip-bot for Masoud Sharbiani @ 2013-09-23 13:37 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, hpa, mingo, rmk+kernel, holt, stable, tglx, gxt,
	msharbiani, vlee

Commit-ID:  4f0acd31c31f03ba42494c8baf6c0465150e2621
Gitweb:     http://git.kernel.org/tip/4f0acd31c31f03ba42494c8baf6c0465150e2621
Author:     Masoud Sharbiani <msharbiani@twitter.com>
AuthorDate: Fri, 20 Sep 2013 15:59:07 -0700
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 23 Sep 2013 10:26:08 +0200

x86/reboot: Add quirk to make Dell C6100 use reboot=pci automatically

Dell PowerEdge C6100 machines fail to completely reboot about 20% of the time.

Signed-off-by: Masoud Sharbiani <msharbiani@twitter.com>
Signed-off-by: Vinson Lee <vlee@twitter.com>
Cc: Robin Holt <holt@sgi.com>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
Cc: <stable@vger.kernel.org>
Link: http://lkml.kernel.org/r/1379717947-18042-1-git-send-email-vlee@freedesktop.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/reboot.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index 563ed91..5f4ad27 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -358,6 +358,22 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Precision M6600"),
 		},
 	},
+	{	/* Handle problems with rebooting on the Dell PowerEdge C6100. */
+		.callback = set_pci_reboot,
+		.ident = "Dell PowerEdge C6100",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "C6100"),
+		},
+	},
+	{	/* Some C6100 machines were shipped with vendor being 'Dell'. */
+		.callback = set_pci_reboot,
+		.ident = "Dell PowerEdge C6100",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "C6100"),
+		},
+	},
 	{ }
 };
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [tip:x86/urgent] x86/reboot: Add quirk to make Dell C6100 use reboot=pci automatically
  2013-09-23 13:37 ` [tip:x86/urgent] x86/reboot: Add quirk to make Dell C6100 use reboot=pci automatically tip-bot for Masoud Sharbiani
@ 2013-09-24 22:55   ` H. Peter Anvin
  0 siblings, 0 replies; 3+ messages in thread
From: H. Peter Anvin @ 2013-09-24 22:55 UTC (permalink / raw)
  To: mingo, hpa, linux-kernel, holt, rmk+kernel, stable, tglx, gxt,
	vlee, msharbiani
  Cc: tip-bot for Masoud Sharbiani, linux-tip-commits

On 09/23/2013 06:37 AM, tip-bot for Masoud Sharbiani wrote:
> 
> diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
> index 563ed91..5f4ad27 100644
> --- a/arch/x86/kernel/reboot.c
> +++ b/arch/x86/kernel/reboot.c
> @@ -358,6 +358,22 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Precision M6600"),
>  		},
>  	},
> +	{	/* Handle problems with rebooting on the Dell PowerEdge C6100. */
> +		.callback = set_pci_reboot,
> +		.ident = "Dell PowerEdge C6100",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "C6100"),
> +		},
> +	},
> +	{	/* Some C6100 machines were shipped with vendor being 'Dell'. */
> +		.callback = set_pci_reboot,
> +		.ident = "Dell PowerEdge C6100",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "C6100"),
> +		},

Aren't these substring matches anyway?  If so, the first entry is redundant.

	-hpa



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-09-24 22:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-20 22:59 [PATCH] x86: Add quirk to make Dell C6100 use reboot=pci Vinson Lee
2013-09-23 13:37 ` [tip:x86/urgent] x86/reboot: Add quirk to make Dell C6100 use reboot=pci automatically tip-bot for Masoud Sharbiani
2013-09-24 22:55   ` H. Peter Anvin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.