All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [PATCH 2/4] tests/fp: Do not build softfloat3 tests if TCG is disabled
Date: Fri, 4 Feb 2022 16:38:48 +0100	[thread overview]
Message-ID: <137a9a4f-c632-105b-315d-ca42dead942f@redhat.com> (raw)
In-Reply-To: <20220204152924.6253-3-f4bug@amsat.org>

On 04/02/2022 16.29, Philippe Mathieu-Daudé wrote:
> Technically we don't need the TCG accelerator to run the
> softfloat3 tests. However it is unlikely an interesting
> build combination. Developers using softfloat3 likely use
> TCG too. Similarly, developers disabling TCG shouldn't
> mind much about softfloat3 tests.
> 
> This reduces a non-TCG build by 474 objects!
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   tests/fp/meson.build | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/tests/fp/meson.build b/tests/fp/meson.build
> index 59776a00a7..60843fce85 100644
> --- a/tests/fp/meson.build
> +++ b/tests/fp/meson.build
> @@ -1,3 +1,6 @@
> +if 'CONFIG_TCG' not in config_all

Alternatively "if not config_all.has_key('CONFIG_TCG')" ? ... not sure which 
one is better, though

> +  subdir_done()
> +endif
>   # There are namespace pollution issues on Windows, due to osdep.h
>   # bringing in Windows headers that define a FLOAT128 type.
>   if targetos == 'windows'

Reviewed-by: Thomas Huth <thuth@redhat.com>



  reply	other threads:[~2022-02-04 15:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-04 15:29 [PATCH 0/4] buildsys: Avoid building unused objects Philippe Mathieu-Daudé via
2022-02-04 15:29 ` [PATCH 1/4] configure: Restrict TCG to emulation Philippe Mathieu-Daudé via
2022-02-04 15:35   ` Thomas Huth
2022-02-04 16:55   ` Paolo Bonzini
2022-02-04 15:29 ` [PATCH 2/4] tests/fp: Do not build softfloat3 tests if TCG is disabled Philippe Mathieu-Daudé via
2022-02-04 15:38   ` Thomas Huth [this message]
2022-02-04 15:29 ` [PATCH 3/4] qom: Remove user-creatable objects from user emulation Philippe Mathieu-Daudé via
2022-02-04 15:56   ` Thomas Huth
2022-02-04 16:14     ` Philippe Mathieu-Daudé via
2022-02-04 16:56   ` Paolo Bonzini
2022-02-04 15:29 ` [PATCH 4/4] qapi/meson: Restrict machine-specific objects to sysemu Philippe Mathieu-Daudé via
2022-02-04 16:25   ` Thomas Huth
2022-02-04 17:00   ` Paolo Bonzini
2022-02-04 23:40     ` Philippe Mathieu-Daudé via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=137a9a4f-c632-105b-315d-ca42dead942f@redhat.com \
    --to=thuth@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.