From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754764Ab3IXV0y (ORCPT ); Tue, 24 Sep 2013 17:26:54 -0400 Received: from merlin.infradead.org ([205.233.59.134]:59429 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877Ab3IXV0x (ORCPT ); Tue, 24 Sep 2013 17:26:53 -0400 Message-ID: <1380058004.9509.1.camel@smoke> Subject: Re: [PATCH 08/10] toshiba: Remove extern from function prototypes From: Geoff Levand To: Joe Perches Cc: netdev@vger.kernel.org, "David S. Miller" , Ishizaki Kou , Jens Osterkamp , cbe-oss-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Tue, 24 Sep 2013 14:26:44 -0700 In-Reply-To: <3e0dd1f4722f8e0c10a47b9bbb26e891e79fef60.1380056108.git.joe@perches.com> References: <3e0dd1f4722f8e0c10a47b9bbb26e891e79fef60.1380056108.git.joe@perches.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2013-09-24 at 14:10 -0700, Joe Perches wrote: > There are a mix of function prototypes with and without extern > in the kernel sources. Standardize on not using extern for > function prototypes. > > Function prototypes don't need to be written with extern. > extern is assumed by the compiler. Its use is as unnecessary as > using auto to declare automatic/local variables in a block. > > Signed-off-by: Joe Perches > --- > drivers/net/ethernet/toshiba/ps3_gelic_net.h | 29 +++++++++++------------ > drivers/net/ethernet/toshiba/ps3_gelic_wireless.h | 6 ++--- > drivers/net/ethernet/toshiba/spider_net.h | 4 ++-- > 3 files changed, 19 insertions(+), 20 deletions(-) Looks good. Thanks. Acked-by: Geoff Levand