From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 04/28] libxl: fix libxl_string_list_length
 and its only caller
Date: Wed, 25 Sep 2013 13:58:17 +0100
Message-ID: <1380113897.23688.143.camel@kazak.uk.xensource.com>
References: <1379475484-25993-1-git-send-email-mattjd@gmail.com>
	<1379475484-25993-5-git-send-email-mattjd@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1379475484-25993-5-git-send-email-mattjd@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Matthew Daley <mattjd@gmail.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2013-09-18 at 15:37 +1200, Matthew Daley wrote:
> The wrong amount of indirections were being taken in
> libxl_string_list_length, and its only caller was miscounting the amount
> of initial non-list arguments, seemingly since the initial commit
> (599c784).
> 
> This has been seen and reported in the wild (##xen):
> < Trixboxer> Hi, any idea why would I get
> < Trixboxer> xl: libxl_bootloader.c:42: bootloader_arg: Assertion `bl->nargs < bl->argsspace' failed.
> < Trixboxer> 4.2.2-23.el6
> 
> Coverity-ID: 1054954
> Signed-off-by: Matthew Daley <mattjd@gmail.com>

acked + applied, thanks