All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@sigma-star.at>
To: Emil Lenngren <emil.lenngren@gmail.com>
Cc: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
	linux-mtd@lists.infradead.org,
	David Oberhollenzer <david.oberhollenzer@sigma-star.at>
Subject: Re: [PATCH v2] mkfs.ubifs: Add ZSTD compression
Date: Fri, 7 Jun 2019 22:24:09 +0200 (CEST)	[thread overview]
Message-ID: <1380627689.233779.1559939049026.JavaMail.zimbra@sigma-star.at> (raw)
In-Reply-To: <CAO1O6sdeY6ZY_PhoZrVuqCg20F0Dt3Y_mXXr-OYUMD4HZMihvg@mail.gmail.com>

Emil,

----- Ursprüngliche Mail -----
> The new mtd-utils with this patch doesn't compile on Ubuntu 18.04 LTS
> since it uses a slightly older version of zstd (1.3.3) that didn't
> have the macro ZSTD_CLEVEL_DEFAULT defined, which was introduced in
> version 1.3.5. Could you maybe consider adding the following lines in
> compr.c:
> 
> #ifndef ZSTD_CLEVEL_DEFAULT
> #define ZSTD_CLEVEL_DEFAULT 3
> #endif
> 
> or similar, which make it compile on slightly older distributions?

If I read the docs correctly, we can just pass 0 as compression level,
which will default to ZSTD_CLEVEL_DEFAULT.
https://github.com/facebook/zstd/pull/1174/commits/e34c000e44444b9f8bd62e5af0a355ee186eb21f

This should work on all zstd versions.

Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2019-06-07 20:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-01 10:43 [PATCH v2] mkfs.ubifs: Add ZSTD compression Sebastian Andrzej Siewior
2019-06-02 21:37 ` David Oberhollenzer
2019-06-07 14:20 ` Emil Lenngren
2019-06-07 20:24   ` Richard Weinberger [this message]
2019-06-10 17:34     ` Emil Lenngren
2019-06-11 17:21       ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1380627689.233779.1559939049026.JavaMail.zimbra@sigma-star.at \
    --to=richard@sigma-star.at \
    --cc=david.oberhollenzer@sigma-star.at \
    --cc=emil.lenngren@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=sebastian@breakpoint.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.