From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756047Ab3JKFQk (ORCPT ); Fri, 11 Oct 2013 01:16:40 -0400 Received: from LGEMRELSE1Q.lge.com ([156.147.1.111]:64088 "EHLO LGEMRELSE1Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753118Ab3JKFPv (ORCPT ); Fri, 11 Oct 2013 01:15:51 -0400 X-AuditID: 9c93016f-b7c63ae00000696f-2a-5257898228c0 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Peter Zijlstra , Paul Mackerras , Ingo Molnar , Namhyung Kim , LKML , Linus Torvalds , Frederic Weisbecker , Jiri Olsa , David Ahern , Ingo Molnar , Arnaldo Carvalho de Melo , Stephane Eranian Subject: [PATCH 7/8] perf tools: Compare hists comm by addresses Date: Fri, 11 Oct 2013 14:15:42 +0900 Message-Id: <1381468543-25334-8-git-send-email-namhyung@kernel.org> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1381468543-25334-1-git-send-email-namhyung@kernel.org> References: <1381468543-25334-1-git-send-email-namhyung@kernel.org> X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frederic Weisbecker Now that comm strings are allocated only once and refcounted to be shared among threads, these can now be safely compared by addresses. This should remove most hists collapses on post processing. Signed-off-by: Frederic Weisbecker Cc: Jiri Olsa Cc: David Ahern Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo Cc: Stephane Eranian Signed-off-by: Namhyung Kim --- tools/perf/util/sort.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index 519a3dde7466..e68833f3932d 100644 --- a/tools/perf/util/sort.c +++ b/tools/perf/util/sort.c @@ -79,7 +79,8 @@ struct sort_entry sort_thread = { static int64_t sort__comm_cmp(struct hist_entry *left, struct hist_entry *right) { - return right->thread->tid - left->thread->tid; + /* Compare the addr that should be unique among comm */ + return thread__comm_str(right->thread) - thread__comm_str(left->thread); } static int64_t -- 1.7.11.7