All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: git@vger.kernel.org
Cc: Felipe Contreras <felipe.contreras@gmail.com>
Subject: [PATCH 18/20] run-command: trivial style fixes
Date: Sat, 12 Oct 2013 02:07:11 -0500	[thread overview]
Message-ID: <1381561636-20717-16-git-send-email-felipe.contreras@gmail.com> (raw)
In-Reply-To: <1381561636-20717-1-git-send-email-felipe.contreras@gmail.com>

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 run-command.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/run-command.c b/run-command.c
index 1b7f88e..3914d9c 100644
--- a/run-command.c
+++ b/run-command.c
@@ -406,13 +406,12 @@ fail_pipe:
 					unsetenv(*cmd->env);
 			}
 		}
-		if (cmd->git_cmd) {
+		if (cmd->git_cmd)
 			execv_git_cmd(cmd->argv);
-		} else if (cmd->use_shell) {
+		else if (cmd->use_shell)
 			execv_shell_cmd(cmd->argv);
-		} else {
+		else
 			sane_execvp(cmd->argv[0], (char *const*) cmd->argv);
-		}
 		if (errno == ENOENT) {
 			if (!cmd->silent_exec_failure)
 				error("cannot run %s: %s", cmd->argv[0],
@@ -446,7 +445,6 @@ fail_pipe:
 		cmd->pid = -1;
 	}
 	close(notify_pipe[0]);
-
 }
 #else
 {
@@ -480,11 +478,10 @@ fail_pipe:
 	if (cmd->env)
 		env = make_augmented_environ(cmd->env);
 
-	if (cmd->git_cmd) {
+	if (cmd->git_cmd)
 		cmd->argv = prepare_git_cmd(cmd->argv);
-	} else if (cmd->use_shell) {
+	else if (cmd->use_shell)
 		cmd->argv = prepare_shell_cmd(cmd->argv);
-	}
 
 	cmd->pid = mingw_spawnvpe(cmd->argv[0], cmd->argv, env, cmd->dir,
 				  fhin, fhout, fherr);
-- 
1.8.4-fc

  parent reply	other threads:[~2013-10-12  7:14 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-12  7:06 [PATCH 10/20] doc: git-foo was obsoleted several years ago Felipe Contreras
2013-10-12  7:06 ` [PATCH 00/20] Trivial paches Felipe Contreras
2013-10-12  7:06 ` [PATCH 03/20] pull: cleanup documentation Felipe Contreras
2013-10-12  7:06 ` [PATCH 20/20] add: avoid yoda conditions Felipe Contreras
2013-10-12  7:07 ` [PATCH 08/20] branch: trivial style fix Felipe Contreras
2013-10-12  7:07 ` [PATCH 15/20] pretty: " Felipe Contreras
2013-10-12  7:07 ` [PATCH 19/20] setup: trivial style fixes Felipe Contreras
2013-10-12  7:07 ` [PATCH 13/20] transport-helper: trivial style fix Felipe Contreras
2013-10-12  7:07 ` [PATCH 01/20] merge: simplify ff-only option Felipe Contreras
2013-10-12  7:07 ` [PATCH 16/20] revision: trivial style fixes Felipe Contreras
2013-10-12  9:08   ` Stefan Beller
2013-10-12 11:18     ` Felipe Contreras
2013-10-12  7:07 ` [PATCH 17/20] diff: trivial style fix Felipe Contreras
2013-10-12  7:07 ` [PATCH 05/20] remote: fix trivial memory leak Felipe Contreras
2013-10-12  7:07 ` [PATCH 07/20] shortlog: add missing declaration Felipe Contreras
2013-10-12  7:07 ` [PATCH 11/20] symbolic-ref: trivial style fix Felipe Contreras
2013-10-12  7:07 ` [PATCH 06/20] revision: add missing include Felipe Contreras
2013-10-12  7:07 ` Felipe Contreras [this message]
2013-10-12  7:07 ` [PATCH 02/20] t: replace pulls with merges Felipe Contreras
2013-10-12  7:07 ` [PATCH 12/20] alias: trivial style fix Felipe Contreras
2013-10-12  8:55   ` Stefan Beller
2013-10-14 14:18     ` Jonathan Nieder
2013-10-14 21:21       ` Felipe Contreras
2013-10-12  7:07 ` [PATCH 04/20] fetch: add missing documentation Felipe Contreras
2013-10-12  7:07 ` [PATCH 09/20] sha1-name: trivial style cleanup Felipe Contreras
2013-10-12  7:07 ` [PATCH 14/20] describe: trivial style fixes Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381561636-20717-16-git-send-email-felipe.contreras@gmail.com \
    --to=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.