From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753387Ab3JVLDw (ORCPT ); Tue, 22 Oct 2013 07:03:52 -0400 Received: from forward-corp1e.mail.yandex.net ([77.88.60.199]:39504 "EHLO forward-corp1e.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753081Ab3JVLD1 (ORCPT ); Tue, 22 Oct 2013 07:03:27 -0400 Authentication-Results: smtpcorp4.mail.yandex.net; dkim=pass header.i=@yandex-team.ru From: Stanislav Fomichev To: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com, acme@ghostprotocols.net Cc: linux-kernel@vger.kernel.org Subject: [PATCH 2/6] perf timechart: use proc_num to implement --power-only Date: Tue, 22 Oct 2013 14:56:48 +0400 Message-Id: <1382439412-23713-3-git-send-email-stfomichev@yandex-team.ru> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1382439412-23713-1-git-send-email-stfomichev@yandex-team.ru> References: <1382439412-23713-1-git-send-email-stfomichev@yandex-team.ru> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Don't use special flag to indicate power-only mode, use proc_num == 0. -P now equals to -n 0 Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-timechart.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c index d965f26308ed..e6c041301aa4 100644 --- a/tools/perf/builtin-timechart.c +++ b/tools/perf/builtin-timechart.c @@ -50,8 +50,6 @@ static u64 turbo_frequency; static u64 first_time, last_time; -static bool power_only; - struct per_pid; struct per_pidcomm; @@ -912,7 +910,7 @@ static int determine_display_tasks(u64 threshold) /* no exit marker, task kept running to the end */ if (p->end_time == 0) p->end_time = last_time; - if (p->total_time >= threshold && !power_only) + if (p->total_time >= threshold) p->display = 1; c = p->all; @@ -923,7 +921,7 @@ static int determine_display_tasks(u64 threshold) if (c->start_time == 1) c->start_time = first_time; - if (c->total_time >= threshold && !power_only) { + if (c->total_time >= threshold) { c->display = 1; count++; } @@ -1086,6 +1084,15 @@ parse_process(const struct option *opt __maybe_unused, const char *arg, return 0; } +static int +parse_power(const struct option *opt __maybe_unused, + const char *arg __maybe_unused, + int unset __maybe_unused) +{ + proc_num = 0; + return 0; +} + int cmd_timechart(int argc, const char **argv, const char *prefix __maybe_unused) { @@ -1094,7 +1101,8 @@ int cmd_timechart(int argc, const char **argv, OPT_STRING('i', "input", &input_name, "file", "input file name"), OPT_STRING('o', "output", &output_name, "file", "output file name"), OPT_INTEGER('w', "width", &svg_page_width, "page width"), - OPT_BOOLEAN('P', "power-only", &power_only, "output power data only"), + OPT_CALLBACK_NOOPT('P', "power-only", NULL, NULL, + "output power data only", parse_power), OPT_CALLBACK('p', "process", NULL, "process", "process selector. Pass a pid or process name.", parse_process), -- 1.8.1.2