From: Szymon Janc <szymon.janc@tieto.com>
To: <linux-bluetooth@vger.kernel.org>
Cc: Szymon Janc <szymon.janc@tieto.com>
Subject: [PATCH v2 2/5] android: Update IPC headers to match SSP and PIN requests events
Date: Tue, 29 Oct 2013 11:16:26 +0100 [thread overview]
Message-ID: <1383041789-28360-2-git-send-email-szymon.janc@tieto.com> (raw)
In-Reply-To: <1383041789-28360-1-git-send-email-szymon.janc@tieto.com>
Name should be 249 bytes so it is always NULL terminated string.
Class of device is send as uint32. This will allow to make simple
passing of data in HAL library without need of copying data.
---
android/hal-msg.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/android/hal-msg.h b/android/hal-msg.h
index a4eb2a8..80b47d6 100644
--- a/android/hal-msg.h
+++ b/android/hal-msg.h
@@ -356,15 +356,15 @@ struct hal_ev_discovery_state_changed {
#define HAL_EV_PIN_REQUEST 0x86
struct hal_ev_pin_request {
uint8_t bdaddr[6];
- uint8_t name[249 - 1];
- uint8_t class_of_dev[3];
+ uint8_t name[249];
+ uint32_t class_of_dev;
} __attribute__((packed));
#define HAL_EV_SSP_REQUEST 0x87
struct hal_ev_ssp_request {
uint8_t bdaddr[6];
- uint8_t name[249 - 1];
- uint8_t class_of_dev[3];
+ uint8_t name[249];
+ uint32_t class_of_dev;
uint8_t pairing_variant;
uint32_t passkey;
} __attribute__((packed));
--
1.8.4.1
next prev parent reply other threads:[~2013-10-29 10:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 10:16 [PATCH v2 1/5] android: Define class of device as four bytes in IPC doc Szymon Janc
2013-10-29 10:16 ` Szymon Janc [this message]
2013-10-29 10:16 ` [PATCH v2 3/5] android/hal: Add support for handling bond state change event Szymon Janc
2013-10-29 10:27 ` Andrei Emeltchenko
2013-10-29 10:32 ` Szymon Janc
2013-10-29 10:38 ` Andrei Emeltchenko
2013-10-29 10:52 ` Szymon Janc
2013-10-29 10:16 ` [PATCH v2 4/5] android/hal: Add support for handling pin request event Szymon Janc
2013-10-29 10:16 ` [PATCH v2 5/5] android/hal: Add support for handling SSP " Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383041789-28360-2-git-send-email-szymon.janc@tieto.com \
--to=szymon.janc@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.