Re: [linux-3.10 bisection] complete test-amd64-i386-qemut-rhel6hvm-intel

[Ian Campbell <Ian.Campbell@citrix.com>]

On Thu, 2013-11-07 at 12:07 +0000, David Vrabel wrote:
> On 07/11/13 04:04, xen.org wrote:
> > branch xen-unstable
> > xen branch xen-unstable
> > job test-amd64-i386-qemut-rhel6hvm-intel
> > test leak-check/check
> > 
> > Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
> > Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
> > Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
> > Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
> > Tree: xen git://xenbits.xen.org/xen.git
> > 
> > *** Found and reproduced problem changeset ***
> > 
> >   Bug is in tree:  linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
> >   Bug introduced:  f495ddc46f97dd0054ff2d5d3c7493d59f7511fb
> >   Bug not present: b9396c4c9e7f499b1dd8080e901c88705f2efa99
> > 
> > 
> >   commit f495ddc46f97dd0054ff2d5d3c7493d59f7511fb
> >   Author: Paul Durrant <paul.durrant@citrix.com>
> >   Date:   Tue Oct 8 14:22:56 2013 +0100
> >   
> >       xen-netback: Don't destroy the netdev until the vif is shut down
> >       
> >       [ upstream commit id: 279f438e36c0a70b23b86d2090aeec50155034a9 ]
> >       
> >       Without this patch, if a frontend cycles through states Closing
> >       and Closed (which Windows frontends need to do) then the netdev
> >       will be destroyed and requires re-invocation of hotplug scripts
> >       to restore state before the frontend can move to Connected. Thus
> >       when udev is not in use the backend gets stuck in InitWait.
> >       
> >       With this patch, the netdev is left alone whilst the backend is
> >       still online and is only de-registered and freed just prior to
> >       destroying the vif (which is also nicely symmetrical with the
> >       netdev allocation and registration being done during probe) so
> >       no re-invocation of hotplug scripts is required.
> >       
> >       Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> >       Cc: David Vrabel <david.vrabel@citrix.com>
> >       Cc: Wei Liu <wei.liu2@citrix.com>
> >       Cc: Ian Campbell <ian.campbell@citrix.com>
> >       Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> The 3.10 stable tree is missing dc62ccaccfb139d9b04bbc5a2688a4402adbfab3
> (xen-netback: transition to CLOSED when removing a VIF) which fixes a
> regression introduced in the above patch.
> 
> This depends on ea732dff5cfa10789007bf4a5b935388a0bb2a8f (xen-netback:
> Handle backend state transitions in a more robust way) which fixes an
> issue with some old Windows frontends.
> 
> Both of these should be backported to stable.

Yes, this was also discussed yesterday in reply to one of the failures.
Has someone pinged DaveM already?

Ian.