From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26C19C433FE for ; Fri, 4 Nov 2022 12:58:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230035AbiKDM61 (ORCPT ); Fri, 4 Nov 2022 08:58:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229745AbiKDM6Y (ORCPT ); Fri, 4 Nov 2022 08:58:24 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F2992E683 for ; Fri, 4 Nov 2022 05:58:19 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id i5-20020a1c3b05000000b003cf47dcd316so5353389wma.4 for ; Fri, 04 Nov 2022 05:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZwyHad34mlqqMFn53iMCM8+Gqhzyvbyy9wGcSB66m8s=; b=neP1+M2g3j63Zk6HSrC43BrOUyCjmbe3/+IvveBVBi7gFujI/d+PxhgurHM3X/AWLP on484xeONjUN3C9AolgI+T10FS8j8TopMXBAWO14HZuYKvgO+eycy2CHuIVgGsjBsj7g 2kurz8SrJM1ePJrlnrfcMAM7ZH5JyzdEaaw8uCXdV5U9EjrNc/yUX4lYJXYRLBMhNI8P FvWZYCEUmwfcwmQUGEJI8WrkGqvfdKiqJ1OUHYs4EhJQOzi0INPeOvoLxoO8Lgg/yLNQ 8O8srjXkSmkuXFCQ59OJG1nXKFKtfI1xxMqqwlm+ryU15Z7qxmhTysmN8vSxZh0lNuQB jAkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZwyHad34mlqqMFn53iMCM8+Gqhzyvbyy9wGcSB66m8s=; b=x+FoPsohV/Pq2yNRzM10Vc9WEHzJW0c3AXKoYJVefJ8v3FqEpQ/lQNYrNvMhtC1VqM 9sy9knbErSyvrrI3k4GCNrK20rafdvcnL/YDvWPQbf6FZfOTYUWqzttyADGxPx5Bmrny h2UDU25dkuDH+hd9IXeyYwDIz1pyh/KN68cDlhZ40FOTh1UO7uXH9fmTyc8x9Fhp1YlS f0ssD/Yil1N/4Fy/mbIh4639N/l6/W0a2IT/OrFpnZmmwfjn87y+EUDp5ktunZin+bb2 HMQRc1dVbFqvmeVf0/2RH5uPCecyi9EdaKqiXf5eYPE19RRIweNun7z89OoXZBhCy3ZV JTHg== X-Gm-Message-State: ACrzQf0vB/Mys+di5vLdDnnydyRUpS9rOGmvonW70gAcbd9L/5wHBIqE 8ePgqg/t8+hXYazTphn4Apg8Tw== X-Google-Smtp-Source: AMsMyM4PSqJTDG/ErJjBhO/AmAS5cO82QRykgTTHga1nzb8GnNE2KHwmgXPc7rwm6thvlMQoPRjSCA== X-Received: by 2002:a05:600c:1819:b0:3cf:63fe:944a with SMTP id n25-20020a05600c181900b003cf63fe944amr23041803wmp.17.1667566697875; Fri, 04 Nov 2022 05:58:17 -0700 (PDT) Received: from [10.101.1.4] (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id p10-20020a05600c1d8a00b003c6bd91caa5sm2941833wms.17.2022.11.04.05.58.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Nov 2022 05:58:17 -0700 (PDT) Message-ID: <1383fd22-c720-811e-a2bb-be2151675089@baylibre.com> Date: Fri, 4 Nov 2022 13:58:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v6 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC Content-Language: en-US To: Lee Jones Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, nm@ti.com, kristo@kernel.org, dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, will@kernel.org, tony@atomide.com, vigneshr@ti.com, bjorn.andersson@linaro.org, shawnguo@kernel.org, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com, afd@ti.com, khilman@baylibre.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org References: <20221011140549.16761-1-jneanne@baylibre.com> <20221011140549.16761-5-jneanne@baylibre.com> From: jerome Neanne In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/10/2022 12:00, Lee Jones wrote: >> diff --git a/include/linux/mfd/tps65219.h b/include/linux/mfd/tps65219.h >> new file mode 100644 >> index 000000000000..2c1cf92e92ac >> --- /dev/null >> +++ b/include/linux/mfd/tps65219.h >> +/** >> + * struct tps65219 - tps65219 sub-driver chip access routines >> + * >> + * Device data may be used to access the TPS65219 chip >> + * >> + * @dev MFD device >> + * @regmap Regmap for accessing the device registers >> + * @irq_data Regmap irq data used for the irq chip >> + * @nb notifier block for the restart handler >> + */ > > This header needs work. I'm not sure to get your point here. Just something like below to match format or do you expect more: /** * struct tps65219 - tps65219 sub-driver chip access routines * * Device data may be used to access the TPS65219 chip * * @dev: MFD device * @regmap: Regmap for accessing the device registers * @irq_data: Regmap irq data used for the irq chip * @nb: notifier block for the restart handler */ > > Can you try an compile with W=1 please. This raise one warning on mfd: drivers/mfd/tps65219.c:28:12: warning: ‘tps65219_soft_shutdown’ defined but not used [-Wunused-function] 28 | static int tps65219_soft_shutdown(struct tps65219 *tps) | ^~~~~~~~~~~~~~~~~~~~~~ soft_shutdown has been validated and is used in TI baseline even if not hooked in upstream version further to this review: https://lore.kernel.org/lkml/20220825150224.826258-5-msp@baylibre.com/ It was a TI requirement to implement it... Let me know if you want me to remove this function or if we can keep it like this. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 165FEC433FE for ; Fri, 4 Nov 2022 12:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BEePaTZ8c8CP9VgFsldjuzVyzkMoW3iPMEshQxNuR1k=; b=AdqHuBntEcL26t Tp85eEhPX08XxCxeOAhyzpaKfvdhfdt3qvJRrviJ2AvicUmgPpnQJP98N3ZzkX+NPc5hZ2yaU/bz8 k7YFMXu08mLazRXkmhJZkmPxv43MTXqmkUnjxu1e2WAsT7ZMsnFBY0ekVHzFJzfiV8y2vxKgjFFV9 8DumxzwsG6vWz/bpjQk5NGi1ZOgapjoEhqTsnJHcIRpM9vDlWiO5E4G+Kycu4AhDmjWE5tKhyl8/b PfwlbV0AJ9hy4Bvb3B7pvDUlDDRnxFGFEDEXPLdB5bzXdtiYjtCyFvW4z44WRvljkHCu7/AMse37r EDFzDtpokcVyDIHXRGBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqwHB-003XxX-BE; Fri, 04 Nov 2022 12:58:25 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqwH6-003XvQ-7A for linux-arm-kernel@lists.infradead.org; Fri, 04 Nov 2022 12:58:22 +0000 Received: by mail-wm1-x32e.google.com with SMTP id ja4-20020a05600c556400b003cf6e77f89cso5383790wmb.0 for ; Fri, 04 Nov 2022 05:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZwyHad34mlqqMFn53iMCM8+Gqhzyvbyy9wGcSB66m8s=; b=neP1+M2g3j63Zk6HSrC43BrOUyCjmbe3/+IvveBVBi7gFujI/d+PxhgurHM3X/AWLP on484xeONjUN3C9AolgI+T10FS8j8TopMXBAWO14HZuYKvgO+eycy2CHuIVgGsjBsj7g 2kurz8SrJM1ePJrlnrfcMAM7ZH5JyzdEaaw8uCXdV5U9EjrNc/yUX4lYJXYRLBMhNI8P FvWZYCEUmwfcwmQUGEJI8WrkGqvfdKiqJ1OUHYs4EhJQOzi0INPeOvoLxoO8Lgg/yLNQ 8O8srjXkSmkuXFCQ59OJG1nXKFKtfI1xxMqqwlm+ryU15Z7qxmhTysmN8vSxZh0lNuQB jAkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZwyHad34mlqqMFn53iMCM8+Gqhzyvbyy9wGcSB66m8s=; b=2EW2uMssiSFew3s3nSHZFmZsF2DU4REkeqw1vUXujGw5vbrxerxw+ZetkV1L0uiu4O CoRWSvM5Ym7quHYisO7MrbotRS3b7+JmasQ/c4M3M2TInb5IlGNTCUDUdDu4wKW89YXP xF0TXL/n3kITOwhlLgSxWrI4JLq+4qjuXUbqR+RvFlG5DUuHYeVz9p39m5fKFrJxyRzf YzY0Mv93K/7G1JfmDCQBzEoi63h2lzJWzcelsMsb5xljnu64Raj+XVlA4dkI1e0UhtQh OIdTTvB/SwSXx5VHkAoY+0HnqfyHyY4/2laza0VBMQB47y+CchAhNBTAGcym8vgbk1QC PGBA== X-Gm-Message-State: ACrzQf0f0gwCqgDmBVpumuQXD7TLODKFoPBcqc2F+bv+Brv3s8X66LXI V3ohLVH+moDx0MmgwZazCN+GlQ== X-Google-Smtp-Source: AMsMyM4PSqJTDG/ErJjBhO/AmAS5cO82QRykgTTHga1nzb8GnNE2KHwmgXPc7rwm6thvlMQoPRjSCA== X-Received: by 2002:a05:600c:1819:b0:3cf:63fe:944a with SMTP id n25-20020a05600c181900b003cf63fe944amr23041803wmp.17.1667566697875; Fri, 04 Nov 2022 05:58:17 -0700 (PDT) Received: from [10.101.1.4] (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id p10-20020a05600c1d8a00b003c6bd91caa5sm2941833wms.17.2022.11.04.05.58.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Nov 2022 05:58:17 -0700 (PDT) Message-ID: <1383fd22-c720-811e-a2bb-be2151675089@baylibre.com> Date: Fri, 4 Nov 2022 13:58:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v6 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC Content-Language: en-US To: Lee Jones Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, nm@ti.com, kristo@kernel.org, dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, will@kernel.org, tony@atomide.com, vigneshr@ti.com, bjorn.andersson@linaro.org, shawnguo@kernel.org, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com, afd@ti.com, khilman@baylibre.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org References: <20221011140549.16761-1-jneanne@baylibre.com> <20221011140549.16761-5-jneanne@baylibre.com> From: jerome Neanne In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221104_055820_478165_0BE702DA X-CRM114-Status: GOOD ( 15.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAzMS8xMC8yMDIyIDEyOjAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4+IGRpZmYgLS1naXQgYS9p bmNsdWRlL2xpbnV4L21mZC90cHM2NTIxOS5oIGIvaW5jbHVkZS9saW51eC9tZmQvdHBzNjUyMTku aAo+PiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+PiBpbmRleCAwMDAwMDAwMDAwMDAuLjJjMWNmOTJl OTJhYwo+PiAtLS0gL2Rldi9udWxsCj4+ICsrKyBiL2luY2x1ZGUvbGludXgvbWZkL3RwczY1MjE5 LmgKCj4+ICsvKioKPj4gKyAqIHN0cnVjdCB0cHM2NTIxOSAtIHRwczY1MjE5IHN1Yi1kcml2ZXIg Y2hpcCBhY2Nlc3Mgcm91dGluZXMKPj4gKyAqCj4+ICsgKiBEZXZpY2UgZGF0YSBtYXkgYmUgdXNl ZCB0byBhY2Nlc3MgdGhlIFRQUzY1MjE5IGNoaXAKPj4gKyAqCj4+ICsgKiBAZGV2IE1GRCBkZXZp Y2UKPj4gKyAqIEByZWdtYXAgUmVnbWFwIGZvciBhY2Nlc3NpbmcgdGhlIGRldmljZSByZWdpc3Rl cnMKPj4gKyAqIEBpcnFfZGF0YSBSZWdtYXAgaXJxIGRhdGEgdXNlZCBmb3IgdGhlIGlycSBjaGlw Cj4+ICsgKiBAbmIgbm90aWZpZXIgYmxvY2sgZm9yIHRoZSByZXN0YXJ0IGhhbmRsZXIKPj4gKyAq Lwo+IAo+IFRoaXMgaGVhZGVyIG5lZWRzIHdvcmsuCkknbSBub3Qgc3VyZSB0byBnZXQgeW91ciBw b2ludCBoZXJlLiBKdXN0IHNvbWV0aGluZyBsaWtlIGJlbG93IHRvIG1hdGNoIApmb3JtYXQgb3Ig ZG8geW91IGV4cGVjdCBtb3JlOgoKLyoqCiAgKiBzdHJ1Y3QgdHBzNjUyMTkgLSB0cHM2NTIxOSBz dWItZHJpdmVyIGNoaXAgYWNjZXNzIHJvdXRpbmVzCiAgKgogICogRGV2aWNlIGRhdGEgbWF5IGJl IHVzZWQgdG8gYWNjZXNzIHRoZSBUUFM2NTIxOSBjaGlwCiAgKgogICogQGRldjogTUZEIGRldmlj ZQogICogQHJlZ21hcDogUmVnbWFwIGZvciBhY2Nlc3NpbmcgdGhlIGRldmljZSByZWdpc3RlcnMK ICAqIEBpcnFfZGF0YTogUmVnbWFwIGlycSBkYXRhIHVzZWQgZm9yIHRoZSBpcnEgY2hpcAogICog QG5iOiBub3RpZmllciBibG9jayBmb3IgdGhlIHJlc3RhcnQgaGFuZGxlcgogICovCgo+IAo+IENh biB5b3UgdHJ5IGFuIGNvbXBpbGUgd2l0aCBXPTEgcGxlYXNlLgpUaGlzIHJhaXNlIG9uZSB3YXJu aW5nIG9uIG1mZDoKZHJpdmVycy9tZmQvdHBzNjUyMTkuYzoyODoxMjogd2FybmluZzog4oCYdHBz NjUyMTlfc29mdF9zaHV0ZG93buKAmSBkZWZpbmVkIApidXQgbm90IHVzZWQgWy1XdW51c2VkLWZ1 bmN0aW9uXQogICAgMjggfCBzdGF0aWMgaW50IHRwczY1MjE5X3NvZnRfc2h1dGRvd24oc3RydWN0 IHRwczY1MjE5ICp0cHMpCiAgICAgICB8ICAgICAgICAgICAgXn5+fn5+fn5+fn5+fn5+fn5+fn5+ fgpzb2Z0X3NodXRkb3duIGhhcyBiZWVuIHZhbGlkYXRlZCBhbmQgaXMgdXNlZCBpbiBUSSBiYXNl bGluZSBldmVuIGlmIG5vdCAKaG9va2VkIGluIHVwc3RyZWFtIHZlcnNpb24gZnVydGhlciB0byB0 aGlzIHJldmlldzoKaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGttbC8yMDIyMDgyNTE1MDIyNC44 MjYyNTgtNS1tc3BAYmF5bGlicmUuY29tLwoKSXQgd2FzIGEgVEkgcmVxdWlyZW1lbnQgdG8gaW1w bGVtZW50IGl0Li4uCkxldCBtZSBrbm93IGlmIHlvdSB3YW50IG1lIHRvIHJlbW92ZSB0aGlzIGZ1 bmN0aW9uIG9yIGlmIHdlIGNhbiBrZWVwIGl0IApsaWtlIHRoaXMuCgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=