From: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfs: fix pnfs Kconfig defaults
Date: Mon, 11 Nov 2013 21:04:54 +0000 [thread overview]
Message-ID: <1384203889.7614.17.camel@leira.trondhjem.org> (raw)
In-Reply-To: <20131111210141.GB13942@infradead.org>
On Mon, 2013-11-11 at 13:01 -0800, Christoph Hellwig wrote:
> On Mon, Nov 11, 2013 at 08:30:48PM +0000, Myklebust, Trond wrote:
> > > diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
> > > index b5e80b0..f731180 100644
> > > --- a/fs/nfs/Kconfig
> > > +++ b/fs/nfs/Kconfig
> > > @@ -116,17 +116,17 @@ config NFS_V4_2
> > > config PNFS_FILE_LAYOUT
> > > tristate
> > > depends on NFS_V4_1
> > > - default m
> > > + default NFS_FS
> >
> > Shouldn?t that really be
> > default NFS_V4
> > in order to get the dependency right? The current Kconfig does allow you to have nfs built in, while leaving NFSv4 as a module.
>
> Probably should. For some reason I had NFS_V4_1 in mind as a bool.
NFS_V4_1 is indeed a bool, but it just defines whether or not we compile
v4.1 behaviour into the 'nfsv4 module' (which is controlled by the
tristate NFS_V4).
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
next prev parent reply other threads:[~2013-11-11 21:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-02 10:22 [PATCH] nfs: fix pnfs Kconfig defaults Christoph Hellwig
2013-11-11 20:30 ` Myklebust, Trond
2013-11-11 21:01 ` Christoph Hellwig
2013-11-11 21:04 ` Myklebust, Trond [this message]
2013-11-11 21:10 ` Christoph Hellwig
2013-11-13 16:50 ` [PATCH v2] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384203889.7614.17.camel@leira.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.