From: Eric Dumazet <eric.dumazet@gmail.com>
To: Nikolay Aleksandrov <nikolay@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
Jay Vosburgh <fubar@us.ibm.com>,
Andy Gospodarek <andy@greyhouse.net>,
Veaceslav Falico <vfalico@redhat.com>
Subject: Re: [PATCH net] bonding: fix two race conditions in bond_store_updelay/downdelay
Date: Wed, 13 Nov 2013 09:38:19 -0800 [thread overview]
Message-ID: <1384364299.28458.129.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <5283B19A.9050302@redhat.com>
On Wed, 2013-11-13 at 18:06 +0100, Nikolay Aleksandrov wrote:
> I thought about this version too, but downdelay/updelay can be changed in other
> places (e.g., store_miimon) and the resulting downdelay/updelay value might not
> be the right one.
> Correct me if I'm wrong, but this is what I have in mind (miimon = 100, updelay
> = 200):
> set miimon to 300 and concurrently set updelay to 400, we might endup leaving
> updelay to 400 because the old value of miimon is used in the calculation in
> store_updelay even though when changing miimon updelay/downdelay get adjusted,
> they might get adjusted by store_updelay/downdelay to a wrong value afterwards.
OK then ;)
next prev parent reply other threads:[~2013-11-13 17:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 16:07 [PATCH net] bonding: fix two race conditions in bond_store_updelay/downdelay Nikolay Aleksandrov
2013-11-13 16:34 ` Nikolay Aleksandrov
2013-11-13 17:03 ` Eric Dumazet
2013-11-13 17:06 ` Nikolay Aleksandrov
2013-11-13 17:38 ` Eric Dumazet [this message]
2013-11-14 1:50 ` Ding Tianhong
2013-11-14 10:17 ` Veaceslav Falico
2013-11-14 21:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384364299.28458.129.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.