From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v5 07/19] xen: arm: allocate dom0 memory separately from preparing the dtb Date: Wed, 13 Nov 2013 20:18:27 +0000 Message-ID: <1384373907.7059.4.camel@dagon.hellion.org.uk> References: <1384366234.29080.8.camel@kazak.uk.xensource.com> <1384366285-29277-7-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: julien.grall@linaro.org, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2013-11-13 at 19:21 +0000, Stefano Stabellini wrote: > On Wed, 13 Nov 2013, Ian Campbell wrote: > > Mixing these two together is a pain, it forces us to prepare the dtb before > > processing the kernel which means we don't know whether the guest is 32- or > > 64-bit while we construct its DTB. > > > > Instead split out the memory allocation (including 1:1 workaround handling) > > and p2m setup into a separate phase and then create a memory node in the DTB > > based on the result. > > > > This allows us to move kernel parsing before DTB setup. > > > > As part of this it was also necessary to rework where the decision regarding > > the placement of the DTB and initrd in RAM was made. It is now made when > > loading the kernel, which allows it to make use of the zImage/ELF specific > > information and therefore to make decisions based on complete knowledge and do > > it right rather than guessing in prepare_dtb and relying on a later check to > > see if things worked. > > > > Signed-off-by: Ian Campbell > > It looks good Can I take that as an Acked-by?