From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Peter Chen <peter.chen@freescale.com>
Cc: alexander.shishkin@linux.intel.com, gregkh@linuxfoundation.org,
rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, swarren@wwwdotorg.org,
ijc+devicetree@hellion.org.uk, davidb@codeaurora.org,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/4] usb: chipidea: msm: Add device tree binding information
Date: Wed, 04 Dec 2013 10:33:57 +0200 [thread overview]
Message-ID: <1386146037.16040.13.camel@iivanov-dev.int.mm-sol.com> (raw)
In-Reply-To: <20131204054003.GB29552@shlinux1.ap.freescale.net>
Hi Peter,
Thank you for reviewing this patch.
On Wed, 2013-12-04 at 13:40 +0800, Peter Chen wrote:
> On Mon, Nov 11, 2013 at 03:35:34PM +0200, Ivan T. Ivanov wrote:
> > From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
> >
>
> Please add something in commit log
>
> > Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
> > Cc: devicetree@vger.kernel.org
> > ---
> > .../devicetree/bindings/usb/msm-hsusb.txt | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/msm-hsusb.txt b/Documentation/devicetree/bindings/usb/msm-hsusb.txt
> > index 5ea26c6..0a85eba 100644
> > --- a/Documentation/devicetree/bindings/usb/msm-hsusb.txt
> > +++ b/Documentation/devicetree/bindings/usb/msm-hsusb.txt
> > @@ -15,3 +15,19 @@ Example EHCI controller device node:
> > usb-phy = <&usb_otg>;
> > };
> >
> > +CI13xxx (Chipidea) USB controllers
> > +
>
> We have already renamed ci13xxx to ci_hdrc.
Yes, but the chip is still CI13XXX. Freescale documentations is also
referring to actual chip family.
>
> > +Required properties:
> > +- compatible: should contain "qcom,ci-hdrc"
> > +- reg: offset and length of the register set in the memory map
> > +- interrupts: interrupt-specifier for the controller interrupt.
> > +- usb-phy: phandle for the PHY device
> > +- dr_mode: Sould be "peripheral"
> > +
>
> Please keep alignment for "reg"
>
It looks aligned in editor with smart-tab support.
Regards,
Ivan
> Peter
>
> > + gadget@f9a55000 {
> > + compatible = "qcom,ci-hdrc";
> > + reg = <0xf9a55000 0x400>;
> > + dr_mode = "peripheral";
> > + interrupts = <0 134 0>;
> > + usb-phy = <&usb_otg>;
> > + };
> > \ No newline at end of file
> > --
> > 1.7.9.5
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
next prev parent reply other threads:[~2013-12-04 8:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 13:35 [PATCH 0/4] usb: chipidea: msm: Clean and fix glue layer driver Ivan T. Ivanov
[not found] ` <1384176937-1658-1-git-send-email-iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2013-11-11 13:35 ` [PATCH 1/4] usb: chipidea: msm: Add device tree binding information Ivan T. Ivanov
2013-11-11 13:35 ` Ivan T. Ivanov
2013-12-04 5:40 ` Peter Chen
2013-12-04 5:40 ` Peter Chen
2013-12-04 8:33 ` Ivan T. Ivanov [this message]
2013-12-04 13:13 ` Peter Chen
2013-12-04 13:13 ` Peter Chen
2013-11-11 13:35 ` [PATCH 2/4] usb: chipidea: msm: Add device tree support Ivan T. Ivanov
2013-11-11 13:35 ` Ivan T. Ivanov
2013-11-11 13:35 ` [PATCH 3/4] usb: chipidea: msm: Initialize offset of the capability registers Ivan T. Ivanov
[not found] ` <1384176937-1658-4-git-send-email-iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2013-12-04 5:43 ` Peter Chen
2013-12-04 5:43 ` Peter Chen
2013-12-04 9:07 ` Ivan T. Ivanov
2013-11-11 13:35 ` [PATCH 4/4] usb: chipidea: msm: Use USB PHY API to control PHY state Ivan T. Ivanov
2013-11-11 13:59 ` Peter Chen
2013-11-11 13:59 ` Peter Chen
2013-11-11 14:36 ` Ivan T. Ivanov
2013-12-04 5:37 ` Peter Chen
2013-12-04 5:37 ` Peter Chen
2013-12-04 9:35 ` Ivan T. Ivanov
2013-12-04 13:38 ` Peter Chen
2013-12-04 13:38 ` Peter Chen
2013-12-11 10:26 ` Ivan T. Ivanov
2013-11-11 14:02 ` [PATCH 0/4] usb: chipidea: msm: Clean and fix glue layer driver Peter Chen
2013-11-11 14:02 ` Peter Chen
2013-11-11 14:49 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386146037.16040.13.camel@iivanov-dev.int.mm-sol.com \
--to=iivanov@mm-sol.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=davidb@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=peter.chen@freescale.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.