All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mm: trivial clean up in insert_page()
@ 2019-05-23 13:40 Miklos Szeredi
  2019-05-24 13:18 ` Anshuman Khandual
  0 siblings, 1 reply; 2+ messages in thread
From: Miklos Szeredi @ 2019-05-23 13:40 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-mm

Make the success case use the same cleanup path as the failure case.

Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
---
 mm/memory.c |    2 --
 1 file changed, 2 deletions(-)

--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1470,8 +1470,6 @@ static int insert_page(struct vm_area_st
 	set_pte_at(mm, addr, pte, mk_pte(page, prot));
 
 	retval = 0;
-	pte_unmap_unlock(pte, ptl);
-	return retval;
 out_unlock:
 	pte_unmap_unlock(pte, ptl);
 out:


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mm: trivial clean up in insert_page()
  2019-05-23 13:40 [PATCH] mm: trivial clean up in insert_page() Miklos Szeredi
@ 2019-05-24 13:18 ` Anshuman Khandual
  0 siblings, 0 replies; 2+ messages in thread
From: Anshuman Khandual @ 2019-05-24 13:18 UTC (permalink / raw)
  To: Miklos Szeredi, Andrew Morton; +Cc: linux-mm



On 05/23/2019 07:10 PM, Miklos Szeredi wrote:
> Make the success case use the same cleanup path as the failure case.
> 
> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-24 13:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-23 13:40 [PATCH] mm: trivial clean up in insert_page() Miklos Szeredi
2019-05-24 13:18 ` Anshuman Khandual

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.