From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751840Ab3LKKRx (ORCPT ); Wed, 11 Dec 2013 05:17:53 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:56422 "EHLO e23smtp08.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751085Ab3LKKQ0 (ORCPT ); Wed, 11 Dec 2013 05:16:26 -0500 From: Wanpeng Li To: Andrew Morton Cc: Ingo Molnar , Rik van Riel , Mel Gorman , Peter Zijlstra , Naoya Horiguchi , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Wanpeng Li Subject: [PATCH v6 6/6] sched/numa: fix period_slot recalculation Date: Wed, 11 Dec 2013 18:16:01 +0800 Message-Id: <1386756961-3887-7-git-send-email-liwanp@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1386756961-3887-1-git-send-email-liwanp@linux.vnet.ibm.com> References: <1386756961-3887-1-git-send-email-liwanp@linux.vnet.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13121110-5140-0000-0000-000004492146 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changelog: v3 -> v4: * remove period_slot recalculation The original code is as intended and was meant to scale the difference between the NUMA_PERIOD_THRESHOLD and local/remote ratio when adjusting the scan period. The period_slot recalculation can be dropped. Reviewed-by: Naoya Horiguchi Acked-by: Mel Gorman Signed-off-by: Wanpeng Li --- kernel/sched/fair.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 8a00879..e7ca79a 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -1356,7 +1356,6 @@ static void update_task_scan_period(struct task_struct *p, * scanning faster if shared accesses dominate as it may * simply bounce migrations uselessly */ - period_slot = DIV_ROUND_UP(diff, NUMA_PERIOD_SLOTS); ratio = DIV_ROUND_UP(private * NUMA_PERIOD_SLOTS, (private + shared)); diff = (diff * ratio) / NUMA_PERIOD_SLOTS; } -- 1.7.5.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f41.google.com (mail-pb0-f41.google.com [209.85.160.41]) by kanga.kvack.org (Postfix) with ESMTP id 5513F6B0039 for ; Wed, 11 Dec 2013 05:16:29 -0500 (EST) Received: by mail-pb0-f41.google.com with SMTP id jt11so9699440pbb.28 for ; Wed, 11 Dec 2013 02:16:29 -0800 (PST) Received: from e23smtp05.au.ibm.com (e23smtp05.au.ibm.com. [202.81.31.147]) by mx.google.com with ESMTPS id ty3si13145327pbc.77.2013.12.11.02.16.26 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 11 Dec 2013 02:16:28 -0800 (PST) Received: from /spool/local by e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 11 Dec 2013 20:16:25 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 6F91B2BB0055 for ; Wed, 11 Dec 2013 21:16:22 +1100 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rBB9w0Lg43253942 for ; Wed, 11 Dec 2013 20:58:01 +1100 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rBBAGLdZ008494 for ; Wed, 11 Dec 2013 21:16:21 +1100 From: Wanpeng Li Subject: [PATCH v6 6/6] sched/numa: fix period_slot recalculation Date: Wed, 11 Dec 2013 18:16:01 +0800 Message-Id: <1386756961-3887-7-git-send-email-liwanp@linux.vnet.ibm.com> In-Reply-To: <1386756961-3887-1-git-send-email-liwanp@linux.vnet.ibm.com> References: <1386756961-3887-1-git-send-email-liwanp@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Ingo Molnar , Rik van Riel , Mel Gorman , Peter Zijlstra , Naoya Horiguchi , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Wanpeng Li Changelog: v3 -> v4: * remove period_slot recalculation The original code is as intended and was meant to scale the difference between the NUMA_PERIOD_THRESHOLD and local/remote ratio when adjusting the scan period. The period_slot recalculation can be dropped. Reviewed-by: Naoya Horiguchi Acked-by: Mel Gorman Signed-off-by: Wanpeng Li --- kernel/sched/fair.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 8a00879..e7ca79a 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -1356,7 +1356,6 @@ static void update_task_scan_period(struct task_struct *p, * scanning faster if shared accesses dominate as it may * simply bounce migrations uselessly */ - period_slot = DIV_ROUND_UP(diff, NUMA_PERIOD_SLOTS); ratio = DIV_ROUND_UP(private * NUMA_PERIOD_SLOTS, (private + shared)); diff = (diff * ratio) / NUMA_PERIOD_SLOTS; } -- 1.7.5.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org