All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: julien.grall@citrix.com, xen-devel@lists.xensource.com
Subject: Re: [PATCH v2 6/6] xen/arm: disable a physical IRQ when the guest disables the corresponding IRQ
Date: Wed, 11 Dec 2013 10:28:30 +0000	[thread overview]
Message-ID: <1386757710.30271.32.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1312101527520.7093@kaball.uk.xensource.com>

On Tue, 2013-12-10 at 18:36 +0000, Stefano Stabellini wrote:
> On Tue, 10 Dec 2013, Ian Campbell wrote:
> > On Tue, 2013-12-10 at 13:06 +0000, Stefano Stabellini wrote:
> > > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > 
> > > Changes in v2:
> > > - disable IRQs that were previously disabled.
> > 
> > These should be after a "---" marker, you've done this wrong
> > consistently in this series.
>  
> Unfortunately guilt doesn't support it. The content I write after "---"
> would get lost.

I suppose guilt uses the same tool as git am to actual apply the patches
on push, so it trims the comments too :-(

> I have the same problem with patch series I send to QEMU and Linux.
> I can either do what I have been doing or avoid writing the log on each
> patch and limiting myself to writing the log to patch #0.
> So far I have been keeping the log as part of the commit messages.

Sounds like a pretty major shortcoming of the tool TBH, perhaps time to
investigate alternatives?

Perhaps git smudge/clean filters could be used such that some other
string is ("--- CUT ME"?) stored in .git/guilt/patches/blah and is
converted on push/refresh etc to ---?

Ian.

  reply	other threads:[~2013-12-11 10:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-10 13:05 [PATCH v2 0/6] interrupt handling fixes Stefano Stabellini
2013-12-10 13:06 ` [PATCH v2 1/6] xen/arm: Physical IRQ is not always equal to virtual IRQ Stefano Stabellini
2013-12-10 13:06 ` [PATCH v2 2/6] xen/arm: track the state of guest IRQs Stefano Stabellini
2013-12-10 13:06 ` [PATCH v2 3/6] xen/arm: do not add a second irq to the LRs if one is already present Stefano Stabellini
2013-12-10 15:22   ` Ian Campbell
2013-12-10 13:06 ` [PATCH v2 4/6] xen/arm: implement gic_irq_enable and gic_irq_disable Stefano Stabellini
2013-12-10 13:06 ` [PATCH v2 5/6] xen/arm: Only enable physical IRQs when the guest asks Stefano Stabellini
2013-12-10 15:18   ` Ian Campbell
2013-12-10 13:06 ` [PATCH v2 6/6] xen/arm: disable a physical IRQ when the guest disables the corresponding IRQ Stefano Stabellini
2013-12-10 15:20   ` Ian Campbell
2013-12-10 18:36     ` Stefano Stabellini
2013-12-11 10:28       ` Ian Campbell [this message]
2013-12-11 19:01         ` Stefano Stabellini
2013-12-12 10:21           ` Ian Campbell
2013-12-10 15:22 ` [PATCH v2 0/6] interrupt handling fixes Ian Campbell
2013-12-10 15:30   ` Julien Grall
2013-12-10 15:36     ` Stefano Stabellini
2013-12-10 16:06       ` Ian Campbell
2013-12-10 16:46         ` Stefano Stabellini
2013-12-10 18:52           ` Stefano Stabellini
2013-12-10 18:34   ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386757710.30271.32.camel@kazak.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=julien.grall@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.