From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH RFC 2/5] Build OVMF for Xen-unstable Date: Wed, 11 Dec 2013 10:29:58 +0000 Message-ID: <1386757798.30271.34.camel@kazak.uk.xensource.com> References: <1386695976-24340-1-git-send-email-wei.liu2@citrix.com> <1386695976-24340-3-git-send-email-wei.liu2@citrix.com> <21159.20142.184300.317319@mariner.uk.xensource.com> <20131210173820.GO32155@zion.uk.xensource.com> <1386697678.30568.67.camel@kazak.uk.xensource.com> <21159.27692.474932.759471@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21159.27692.474932.759471@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: George Dunlap , Wei Liu , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, 2013-12-10 at 19:31 +0000, Ian Jackson wrote: > Ian Campbell writes ("Re: [PATCH RFC 2/5] Build OVMF for Xen-unstable"): > > On Tue, 2013-12-10 at 17:38 +0000, Wei Liu wrote: > > > I think it is OK to arrange this to go in right away. > > > > This has some subset of the same risks as the patch to enable it by > > default (i.e. it causes grief in the push gate) -- it might be wise at > > this stage of the release to involve George in these sorts of decisions > > for osstest? > > If it causes grief in the push gate, it will only be a problem for the > release process if that grief is nondeterministic - since osstest has > its own push gate for its own code. Yes, my concern was that it would make it into the main osstest system and then cause spurious failures and get in the way etc. That's as much a risk to the release process as any other code change I think. > If it causes grief in the osstest self-push-gate, I can revert it. Or indeed if it turns out to cause grief in the system once pushed. Ian.