All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Adrian Hunter <adrian.hunter@intel.com>,
	Andi Kleen <ak@linux.intel.com>, David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@redhat.com>,
	Mike Galbraith <efault@gmx.de>, Namhyung Kim <namhyung@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Stephane Eranian <eranian@google.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 05/20] perf tools: Move mem_bswap32/64 to util.c
Date: Fri, 13 Dec 2013 12:11:51 -0300	[thread overview]
Message-ID: <1386947526-7118-6-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1386947526-7118-1-git-send-email-acme@infradead.org>

From: Adrian Hunter <adrian.hunter@intel.com>

Move functions mem_bswap_32() and mem_bswap_64() so they can be reused.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1386765443-26966-21-git-send-email-alexander.shishkin@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/session.c | 21 ---------------------
 tools/perf/util/session.h |  2 --
 tools/perf/util/util.c    | 22 ++++++++++++++++++++++
 tools/perf/util/util.h    |  3 +++
 4 files changed, 25 insertions(+), 23 deletions(-)

diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index e748f29c53cf..989b2e377626 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -247,27 +247,6 @@ void perf_tool__fill_defaults(struct perf_tool *tool)
 	}
 }
  
-void mem_bswap_32(void *src, int byte_size)
-{
-	u32 *m = src;
-	while (byte_size > 0) {
-		*m = bswap_32(*m);
-		byte_size -= sizeof(u32);
-		++m;
-	}
-}
-
-void mem_bswap_64(void *src, int byte_size)
-{
-	u64 *m = src;
-
-	while (byte_size > 0) {
-		*m = bswap_64(*m);
-		byte_size -= sizeof(u64);
-		++m;
-	}
-}
-
 static void swap_sample_id_all(union perf_event *event, void *data)
 {
 	void *end = (void *) event + event->header.size;
diff --git a/tools/perf/util/session.h b/tools/perf/util/session.h
index 2a3955ea4fd8..9c25d49900af 100644
--- a/tools/perf/util/session.h
+++ b/tools/perf/util/session.h
@@ -74,8 +74,6 @@ int perf_session__resolve_callchain(struct perf_session *session,
 
 bool perf_session__has_traces(struct perf_session *session, const char *msg);
 
-void mem_bswap_64(void *src, int byte_size);
-void mem_bswap_32(void *src, int byte_size);
 void perf_event__attr_swap(struct perf_event_attr *attr);
 
 int perf_session__create_kernel_maps(struct perf_session *session);
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index 8f63dba212d7..42ad667bb317 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -10,6 +10,7 @@
 #include <string.h>
 #include <errno.h>
 #include <limits.h>
+#include <byteswap.h>
 #include <linux/kernel.h>
 
 /*
@@ -515,3 +516,24 @@ int perf_event_paranoid(void)
 
 	return value;
 }
+
+void mem_bswap_32(void *src, int byte_size)
+{
+	u32 *m = src;
+	while (byte_size > 0) {
+		*m = bswap_32(*m);
+		byte_size -= sizeof(u32);
+		++m;
+	}
+}
+
+void mem_bswap_64(void *src, int byte_size)
+{
+	u64 *m = src;
+
+	while (byte_size > 0) {
+		*m = bswap_64(*m);
+		byte_size -= sizeof(u64);
+		++m;
+	}
+}
diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
index 1e7d4136cc82..a1eea3e809a3 100644
--- a/tools/perf/util/util.h
+++ b/tools/perf/util/util.h
@@ -323,5 +323,8 @@ int filename__read_int(const char *filename, int *value);
 int filename__read_str(const char *filename, char **buf, size_t *sizep);
 int perf_event_paranoid(void);
 
+void mem_bswap_64(void *src, int byte_size);
+void mem_bswap_32(void *src, int byte_size);
+
 const char *get_filename_for_perf_kvm(void);
 #endif /* GIT_COMPAT_UTIL_H */
-- 
1.8.1.4


  parent reply	other threads:[~2013-12-13 15:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-13 15:11 [GIT PULL 00/20] perf/core improvements and fixes Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 01/20] tools lib symbol: Start carving out symbol parsing routines from perf Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 02/20] perf tools: Add perf_event_paranoid() Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 03/20] perf header: Allow header->data_offset to be predetermined Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 04/20] perf evlist: Add can_select_event() method Arnaldo Carvalho de Melo
2013-12-13 15:11 ` Arnaldo Carvalho de Melo [this message]
2013-12-13 15:11 ` [PATCH 06/20] perf tools: Fix inverted error verification bug in thread__fork Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 07/20] perf evlist: Add perf_evlist__to_front() Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 08/20] perf completion: Complete 'perf kvm' Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 09/20] tools lib traceevent: Get rid of malloc_or_die() in show_error() Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 10/20] tools lib traceevent: Get rid of die in add_filter_type() Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 11/20] tools lib traceevent: Get rid of malloc_or_die() allocate_arg() Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 12/20] tools lib traceevent: Get rid of malloc_or_die() in read_token() Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 13/20] tools lib traceevent: Get rid of malloc_or_die() in find_event() Arnaldo Carvalho de Melo
2013-12-13 15:12 ` [PATCH 14/20] tools lib traceevent: Get rid of die() in add_right() Arnaldo Carvalho de Melo
2013-12-13 15:12 ` [PATCH 15/20] tools lib traceevent: Make add_left() return pevent_errno Arnaldo Carvalho de Melo
2013-12-13 15:12 ` [PATCH 16/20] tools lib traceevent: Get rid of die() in reparent_op_arg() Arnaldo Carvalho de Melo
2013-12-13 15:12 ` [PATCH 17/20] tools lib traceevent: Refactor create_arg_item() Arnaldo Carvalho de Melo
2013-12-13 15:12 ` [PATCH 18/20] tools lib traceevent: Refactor process_filter() Arnaldo Carvalho de Melo
2013-12-13 15:12 ` [PATCH 19/20] tools lib traceevent: Make pevent_filter_add_filter_str() return pevent_errno Arnaldo Carvalho de Melo
2013-12-13 15:12 ` [PATCH 20/20] tools lib traceevent: Refactor pevent_filter_match() to get rid of die() Arnaldo Carvalho de Melo
2013-12-16 13:54 ` [GIT PULL 00/20] perf/core improvements and fixes Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386947526-7118-6-git-send-email-acme@infradead.org \
    --to=acme@infradead.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=dsahern@gmail.com \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@gmail.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.