All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v2] nand_util.c: Use '%zd' for length in nand_unlock debug print
@ 2013-12-16 14:59 Tom Rini
  2013-12-16 18:20 ` Scott Wood
  2013-12-17 23:45 ` [U-Boot] [U-Boot, " Scott Wood
  0 siblings, 2 replies; 3+ messages in thread
From: Tom Rini @ 2013-12-16 14:59 UTC (permalink / raw)
  To: u-boot

length is size_t so needs to be '%zd' not '%d' to avoid warnings.

Cc: Scott Wood <scottwood@freescale.com>
Signed-off-by: Tom Rini <trini@ti.com>

---
Changes in v2:
- Use %zd, the correct format, rather than %ld, a differntly incorrect
  one.
---
 drivers/mtd/nand/nand_util.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/nand_util.c b/drivers/mtd/nand/nand_util.c
index eeaa7e8..b292826 100644
--- a/drivers/mtd/nand/nand_util.c
+++ b/drivers/mtd/nand/nand_util.c
@@ -315,7 +315,7 @@ int nand_unlock(struct mtd_info *mtd, loff_t start, size_t length,
 	int page;
 	struct nand_chip *chip = mtd->priv;
 
-	debug("nand_unlock%s: start: %08llx, length: %d!\n",
+	debug("nand_unlock%s: start: %08llx, length: %zd!\n",
 		allexcept ? " (allexcept)" : "", start, length);
 
 	/* select the NAND device */
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH v2] nand_util.c: Use '%zd' for length in nand_unlock debug print
  2013-12-16 14:59 [U-Boot] [PATCH v2] nand_util.c: Use '%zd' for length in nand_unlock debug print Tom Rini
@ 2013-12-16 18:20 ` Scott Wood
  2013-12-17 23:45 ` [U-Boot] [U-Boot, " Scott Wood
  1 sibling, 0 replies; 3+ messages in thread
From: Scott Wood @ 2013-12-16 18:20 UTC (permalink / raw)
  To: u-boot

On Mon, 2013-12-16 at 09:59 -0500, Tom Rini wrote:
> length is size_t so needs to be '%zd' not '%d' to avoid warnings.
> 
> Cc: Scott Wood <scottwood@freescale.com>
> Signed-off-by: Tom Rini <trini@ti.com>
> 
> ---
> Changes in v2:
> - Use %zd, the correct format, rather than %ld, a differntly incorrect
>   one.
> ---
>  drivers/mtd/nand/nand_util.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/nand_util.c b/drivers/mtd/nand/nand_util.c
> index eeaa7e8..b292826 100644
> --- a/drivers/mtd/nand/nand_util.c
> +++ b/drivers/mtd/nand/nand_util.c
> @@ -315,7 +315,7 @@ int nand_unlock(struct mtd_info *mtd, loff_t start, size_t length,
>  	int page;
>  	struct nand_chip *chip = mtd->priv;
>  
> -	debug("nand_unlock%s: start: %08llx, length: %d!\n",
> +	debug("nand_unlock%s: start: %08llx, length: %zd!\n",
>  		allexcept ? " (allexcept)" : "", start, length);
>  
>  	/* select the NAND device */

Acked-by: Scott Wood <scottwood@freescale.com>

Though length should really be a loff_t instead.

-Scott

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [U-Boot, v2] nand_util.c: Use '%zd' for length in nand_unlock debug print
  2013-12-16 14:59 [U-Boot] [PATCH v2] nand_util.c: Use '%zd' for length in nand_unlock debug print Tom Rini
  2013-12-16 18:20 ` Scott Wood
@ 2013-12-17 23:45 ` Scott Wood
  1 sibling, 0 replies; 3+ messages in thread
From: Scott Wood @ 2013-12-17 23:45 UTC (permalink / raw)
  To: u-boot

On Mon, Dec 16, 2013 at 09:59:34AM -0500, Tom Rini wrote:
> length is size_t so needs to be '%zd' not '%d' to avoid warnings.
> 
> Cc: Scott Wood <scottwood@freescale.com>
> Signed-off-by: Tom Rini <trini@ti.com>
> Acked-by: Scott Wood <scottwood@freescale.com>
> 
> ---
> Changes in v2:
> - Use %zd, the correct format, rather than %ld, a differntly incorrect
>   one.
> ---
>  drivers/mtd/nand/nand_util.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to u-boot-nand-flash.git

-Scott

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-12-17 23:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-16 14:59 [U-Boot] [PATCH v2] nand_util.c: Use '%zd' for length in nand_unlock debug print Tom Rini
2013-12-16 18:20 ` Scott Wood
2013-12-17 23:45 ` [U-Boot] [U-Boot, " Scott Wood

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.