All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] nand_util.c: Use '%zd' for length in nand_unlock debug print
Date: Mon, 16 Dec 2013 12:20:37 -0600	[thread overview]
Message-ID: <1387218037.10013.346.camel@snotra.buserror.net> (raw)
In-Reply-To: <1387205974-23969-1-git-send-email-trini@ti.com>

On Mon, 2013-12-16 at 09:59 -0500, Tom Rini wrote:
> length is size_t so needs to be '%zd' not '%d' to avoid warnings.
> 
> Cc: Scott Wood <scottwood@freescale.com>
> Signed-off-by: Tom Rini <trini@ti.com>
> 
> ---
> Changes in v2:
> - Use %zd, the correct format, rather than %ld, a differntly incorrect
>   one.
> ---
>  drivers/mtd/nand/nand_util.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/nand_util.c b/drivers/mtd/nand/nand_util.c
> index eeaa7e8..b292826 100644
> --- a/drivers/mtd/nand/nand_util.c
> +++ b/drivers/mtd/nand/nand_util.c
> @@ -315,7 +315,7 @@ int nand_unlock(struct mtd_info *mtd, loff_t start, size_t length,
>  	int page;
>  	struct nand_chip *chip = mtd->priv;
>  
> -	debug("nand_unlock%s: start: %08llx, length: %d!\n",
> +	debug("nand_unlock%s: start: %08llx, length: %zd!\n",
>  		allexcept ? " (allexcept)" : "", start, length);
>  
>  	/* select the NAND device */

Acked-by: Scott Wood <scottwood@freescale.com>

Though length should really be a loff_t instead.

-Scott

  reply	other threads:[~2013-12-16 18:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16 14:59 [U-Boot] [PATCH v2] nand_util.c: Use '%zd' for length in nand_unlock debug print Tom Rini
2013-12-16 18:20 ` Scott Wood [this message]
2013-12-17 23:45 ` [U-Boot] [U-Boot, " Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387218037.10013.346.camel@snotra.buserror.net \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.