All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mtd-utils: nanddump: write requested length only
@ 2013-12-18  1:03 Gary Bisson
  0 siblings, 0 replies; only message in thread
From: Gary Bisson @ 2013-12-18  1:03 UTC (permalink / raw)
  To: linux-mtd; +Cc: Gary Bisson

nanddump was always writing a whole page of data into the output
discarding the length actually requested. This patch allows to
write only the remaining length if oob is omitted. In case oob
is needed, it makes sense to copy the entire page.
---
 nanddump.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/nanddump.c b/nanddump.c
index 4ee7ed4..300aca6 100644
--- a/nanddump.c
+++ b/nanddump.c
@@ -445,8 +445,14 @@ int main(int argc, char * const argv[])
 						pretty_buf, PRETTY_BUF_LEN, true, canonical, ofs + i);
 				write(ofd, pretty_buf, strlen(pretty_buf));
 			}
-		} else
-			write(ofd, readbuf, bs);
+		} else {
+			/* Write requested length if oob is omitted */
+			size_t size_left = end_addr - ofs;
+			if (omitoob && (size_left < bs))
+				write(ofd, readbuf, size_left);
+			else
+				write(ofd, readbuf, bs);
+		}
 
 		if (omitoob)
 			continue;
-- 
1.8.5.1

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-12-18  1:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-18  1:03 [PATCH] mtd-utils: nanddump: write requested length only Gary Bisson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.