All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] madvise07: Increase probability of testing a	supported page type
Date: Wed, 30 Aug 2017 03:51:25 -0400 (EDT)	[thread overview]
Message-ID: <1387821959.5916937.1504079485373.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170828134827.5871-1-rpalethorpe@suse.com>


----- Original Message -----
> We were attempting to poison page types which do not support it (e.g. the
> zero
> page) due to our usage of mmap. Now we map some anonymous memory and write to
> it. Hopefully ensuring the underlying page is of a supported type.
> + * If the underlying page type of the memory we have mapped does not support
> + * poisoning then the test will fail. We try to map and write to the memory
> in
> + * such a way that by the time madvise is called the virtual memory address
> + * points to a supported page. However there may be some rare circumstances
> + * where the test produces the wrong result because we have somehow obtained
> + * an unsupported page.

Hi,

Can you elaborate please? If we always do mmap+touch anonymous memory,
how would we sometime end up with different page type?

I don't have objections to patch, but I'm thinking if we should go
further if there's possibility the test still won't be reliable.
We could relax the condition, for example by FAILing only if
child dies unexpectedly (signal != SIGBUS).

Regards,
Jan

  reply	other threads:[~2017-08-30  7:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-28 13:48 [LTP] [PATCH] madvise07: Increase probability of testing a supported page type Richard Palethorpe
2017-08-30  7:51 ` Jan Stancek [this message]
2017-09-01 12:44   ` Richard Palethorpe
2017-09-12 15:45   ` Cyril Hrubis
2017-09-13 10:08     ` Jan Stancek
2017-09-13 12:44       ` Cyril Hrubis
2017-09-13 12:45 ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387821959.5916937.1504079485373.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.