All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] ata: pata_samsung_cf: Move plat/regs-ata.h to drivers/ata
@ 2013-12-31  5:29 Sachin Kamat
  2013-12-31  6:32 ` Jingoo Han
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Sachin Kamat @ 2013-12-31  5:29 UTC (permalink / raw)
  To: linux-ide; +Cc: linux-samsung-soc, kgene.kim, tj, sachin.kamat, patches

plat/regs-ata.h is used only by Samsung PATA driver.
Move this file to the drivers folder to remove platform
dependency required for multiplatform support.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/ata/pata_samsung_cf.c                      |    2 +-
 .../regs-ata.h => drivers/ata/pata_samsung_cf.h    |    9 ++++-----
 2 files changed, 5 insertions(+), 6 deletions(-)
 rename arch/arm/plat-samsung/include/plat/regs-ata.h => drivers/ata/pata_samsung_cf.h (91%)

diff --git a/drivers/ata/pata_samsung_cf.c b/drivers/ata/pata_samsung_cf.c
index 898e544a7ae8..e04d70b7ce76 100644
--- a/drivers/ata/pata_samsung_cf.c
+++ b/drivers/ata/pata_samsung_cf.c
@@ -24,7 +24,7 @@
 #include <linux/slab.h>
 
 #include <linux/platform_data/ata-samsung_cf.h>
-#include <plat/regs-ata.h>
+#include "pata_samsung_cf.h"
 
 #define DRV_NAME "pata_samsung_cf"
 #define DRV_VERSION "0.1"
diff --git a/arch/arm/plat-samsung/include/plat/regs-ata.h b/drivers/ata/pata_samsung_cf.h
similarity index 91%
rename from arch/arm/plat-samsung/include/plat/regs-ata.h
rename to drivers/ata/pata_samsung_cf.h
index f5df92fdae26..eeefe2e0cdc6 100644
--- a/arch/arm/plat-samsung/include/plat/regs-ata.h
+++ b/drivers/ata/pata_samsung_cf.h
@@ -1,5 +1,4 @@
-/* linux/arch/arm/plat-samsung/include/plat/regs-ata.h
- *
+/*
  * Copyright (c) 2010 Samsung Electronics Co., Ltd.
  *		http://www.samsung.com
  *
@@ -10,8 +9,8 @@
  * published by the Free Software Foundation.
 */
 
-#ifndef __ASM_PLAT_REGS_ATA_H
-#define __ASM_PLAT_REGS_ATA_H __FILE__
+#ifndef __PATA_SAMSUNG_CF_H
+#define __PATA_SAMSUNG_CF_H
 
 #define S3C_CFATA_REG(x)	(x)
 
@@ -53,4 +52,4 @@
 #define S3C_ATA_CFG_SWAP	0x40
 #define S3C_ATA_CFG_IORDYEN	0x02
 
-#endif /* __ASM_PLAT_REGS_ATA_H */
+#endif /* __PATA_SAMSUNG_CF_H */
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] ata: pata_samsung_cf: Move plat/regs-ata.h to drivers/ata
  2013-12-31  5:29 [PATCH 1/1] ata: pata_samsung_cf: Move plat/regs-ata.h to drivers/ata Sachin Kamat
@ 2013-12-31  6:32 ` Jingoo Han
  2013-12-31 11:34 ` Tejun Heo
  2014-01-04  2:00 ` kgene
  2 siblings, 0 replies; 7+ messages in thread
From: Jingoo Han @ 2013-12-31  6:32 UTC (permalink / raw)
  To: 'Sachin Kamat', 'Tejun Heo'
  Cc: linux-ide, linux-samsung-soc, 'Kukjin Kim',
	patches, 'Jingoo Han'

On Tuesday, December 31, 2013 2:29 PM, Sachin Kamat wrote:
> 
> plat/regs-ata.h is used only by Samsung PATA driver.
> Move this file to the drivers folder to remove platform
> dependency required for multiplatform support.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Reviewed-by: Jingoo Han <jg1.han@samsung.com>

Best regards,
Jingoo Han

> ---
>  drivers/ata/pata_samsung_cf.c                      |    2 +-
>  .../regs-ata.h => drivers/ata/pata_samsung_cf.h    |    9 ++++-----
>  2 files changed, 5 insertions(+), 6 deletions(-)
>  rename arch/arm/plat-samsung/include/plat/regs-ata.h => drivers/ata/pata_samsung_cf.h (91%)
> 
> diff --git a/drivers/ata/pata_samsung_cf.c b/drivers/ata/pata_samsung_cf.c
> index 898e544a7ae8..e04d70b7ce76 100644
> --- a/drivers/ata/pata_samsung_cf.c
> +++ b/drivers/ata/pata_samsung_cf.c
> @@ -24,7 +24,7 @@
>  #include <linux/slab.h>
> 
>  #include <linux/platform_data/ata-samsung_cf.h>
> -#include <plat/regs-ata.h>
> +#include "pata_samsung_cf.h"
> 
>  #define DRV_NAME "pata_samsung_cf"
>  #define DRV_VERSION "0.1"
> diff --git a/arch/arm/plat-samsung/include/plat/regs-ata.h b/drivers/ata/pata_samsung_cf.h
> similarity index 91%
> rename from arch/arm/plat-samsung/include/plat/regs-ata.h
> rename to drivers/ata/pata_samsung_cf.h
> index f5df92fdae26..eeefe2e0cdc6 100644
> --- a/arch/arm/plat-samsung/include/plat/regs-ata.h
> +++ b/drivers/ata/pata_samsung_cf.h
> @@ -1,5 +1,4 @@
> -/* linux/arch/arm/plat-samsung/include/plat/regs-ata.h
> - *
> +/*
>   * Copyright (c) 2010 Samsung Electronics Co., Ltd.
>   *		http://www.samsung.com
>   *
> @@ -10,8 +9,8 @@
>   * published by the Free Software Foundation.
>  */
> 
> -#ifndef __ASM_PLAT_REGS_ATA_H
> -#define __ASM_PLAT_REGS_ATA_H __FILE__
> +#ifndef __PATA_SAMSUNG_CF_H
> +#define __PATA_SAMSUNG_CF_H
> 
>  #define S3C_CFATA_REG(x)	(x)
> 
> @@ -53,4 +52,4 @@
>  #define S3C_ATA_CFG_SWAP	0x40
>  #define S3C_ATA_CFG_IORDYEN	0x02
> 
> -#endif /* __ASM_PLAT_REGS_ATA_H */
> +#endif /* __PATA_SAMSUNG_CF_H */
> --
> 1.7.9.5
> 
> --


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] ata: pata_samsung_cf: Move plat/regs-ata.h to drivers/ata
  2013-12-31  5:29 [PATCH 1/1] ata: pata_samsung_cf: Move plat/regs-ata.h to drivers/ata Sachin Kamat
  2013-12-31  6:32 ` Jingoo Han
@ 2013-12-31 11:34 ` Tejun Heo
  2014-01-02  0:49     ` Jingoo Han
  2014-01-04  2:25   ` kgene
  2014-01-04  2:00 ` kgene
  2 siblings, 2 replies; 7+ messages in thread
From: Tejun Heo @ 2013-12-31 11:34 UTC (permalink / raw)
  To: Sachin Kamat; +Cc: linux-ide, linux-samsung-soc, kgene.kim, patches

On Tue, Dec 31, 2013 at 10:59:13AM +0530, Sachin Kamat wrote:
> plat/regs-ata.h is used only by Samsung PATA driver.
> Move this file to the drivers folder to remove platform
> dependency required for multiplatform support.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Applied to libata/for-3.14.

As this is only used by pata_samsung_cf.c, can you please follow up
with a patch to roll pata_samsung_cf.h into .c?  There's no point in
creating separate header files for stuff which isn't shared among
multiple files.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] ata: pata_samsung_cf: Move plat/regs-ata.h to drivers/ata
  2013-12-31 11:34 ` Tejun Heo
@ 2014-01-02  0:49     ` Jingoo Han
  2014-01-04  2:25   ` kgene
  1 sibling, 0 replies; 7+ messages in thread
From: Jingoo Han @ 2014-01-02  0:49 UTC (permalink / raw)
  To: 'Sachin Kamat'
  Cc: 'Tejun Heo',
	linux-ide, linux-samsung-soc, kgene.kim, patches,
	'Brian Norris', linux-mtd, 'Jingoo Han'

On Tuesday, December 31, 2013 8:34 PM, Tejun Heo wrote:
> On Tue, Dec 31, 2013 at 10:59:13AM +0530, Sachin Kamat wrote:
> > plat/regs-ata.h is used only by Samsung PATA driver.
> > Move this file to the drivers folder to remove platform
> > dependency required for multiplatform support.
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> 
> Applied to libata/for-3.14.
> 
> As this is only used by pata_samsung_cf.c, can you please follow up
> with a patch to roll pata_samsung_cf.h into .c?  There's no point in
> creating separate header files for stuff which isn't shared among
> multiple files.

(+cc Brian Norris, linux-mtd mailing list)

Right, I also agree with Tejun's opinion.
Would you also send the patch to roll .h into .c for your another
patch "mtd: s3c2410: Move plat/regs-nand.h to drivers/mtd"?
(http://www.spinics.net/lists/linux-samsung-soc/msg25498.html)

Best regards,
Jingoo Han

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] ata: pata_samsung_cf: Move plat/regs-ata.h to drivers/ata
@ 2014-01-02  0:49     ` Jingoo Han
  0 siblings, 0 replies; 7+ messages in thread
From: Jingoo Han @ 2014-01-02  0:49 UTC (permalink / raw)
  To: 'Sachin Kamat'
  Cc: linux-samsung-soc, patches, 'Jingoo Han',
	linux-ide, kgene.kim, linux-mtd, 'Tejun Heo',
	'Brian Norris'

On Tuesday, December 31, 2013 8:34 PM, Tejun Heo wrote:
> On Tue, Dec 31, 2013 at 10:59:13AM +0530, Sachin Kamat wrote:
> > plat/regs-ata.h is used only by Samsung PATA driver.
> > Move this file to the drivers folder to remove platform
> > dependency required for multiplatform support.
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> 
> Applied to libata/for-3.14.
> 
> As this is only used by pata_samsung_cf.c, can you please follow up
> with a patch to roll pata_samsung_cf.h into .c?  There's no point in
> creating separate header files for stuff which isn't shared among
> multiple files.

(+cc Brian Norris, linux-mtd mailing list)

Right, I also agree with Tejun's opinion.
Would you also send the patch to roll .h into .c for your another
patch "mtd: s3c2410: Move plat/regs-nand.h to drivers/mtd"?
(http://www.spinics.net/lists/linux-samsung-soc/msg25498.html)

Best regards,
Jingoo Han

^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [PATCH 1/1] ata: pata_samsung_cf: Move plat/regs-ata.h to drivers/ata
  2013-12-31  5:29 [PATCH 1/1] ata: pata_samsung_cf: Move plat/regs-ata.h to drivers/ata Sachin Kamat
  2013-12-31  6:32 ` Jingoo Han
  2013-12-31 11:34 ` Tejun Heo
@ 2014-01-04  2:00 ` kgene
  2 siblings, 0 replies; 7+ messages in thread
From: kgene @ 2014-01-04  2:00 UTC (permalink / raw)
  To: 'Sachin Kamat', linux-ide; +Cc: linux-samsung-soc, tj, patches

Sachin Kamat wrote:
> 
> plat/regs-ata.h is used only by Samsung PATA driver.
> Move this file to the drivers folder to remove platform
> dependency required for multiplatform support.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/ata/pata_samsung_cf.c                      |    2 +-
>  .../regs-ata.h => drivers/ata/pata_samsung_cf.h    |    9 ++++-----
>  2 files changed, 5 insertions(+), 6 deletions(-)
>  rename arch/arm/plat-samsung/include/plat/regs-ata.h =>
> drivers/ata/pata_samsung_cf.h (91%)
> 
I don't know we need to create header file into drivers/ata/ because the
header will be used for only pata_samsung_cf.c. But it's up to Tejun who is
a maintainer of SERIAL ATA ;-)

Thanks,
Kukjin

^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [PATCH 1/1] ata: pata_samsung_cf: Move plat/regs-ata.h to drivers/ata
  2013-12-31 11:34 ` Tejun Heo
  2014-01-02  0:49     ` Jingoo Han
@ 2014-01-04  2:25   ` kgene
  1 sibling, 0 replies; 7+ messages in thread
From: kgene @ 2014-01-04  2:25 UTC (permalink / raw)
  To: 'Tejun Heo', 'Sachin Kamat'
  Cc: linux-ide, linux-samsung-soc, patches

Tejun Heo wrote:
> 
> On Tue, Dec 31, 2013 at 10:59:13AM +0530, Sachin Kamat wrote:
> > plat/regs-ata.h is used only by Samsung PATA driver.
> > Move this file to the drivers folder to remove platform
> > dependency required for multiplatform support.
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> 
> Applied to libata/for-3.14.
> 
> As this is only used by pata_samsung_cf.c, can you please follow up
> with a patch to roll pata_samsung_cf.h into .c?  There's no point in
> creating separate header files for stuff which isn't shared among
> multiple files.
> 
Oops, I read this just now ;-)

Tejun, if you've applied this in your tree already, I'm OK so please kindly
ignore my previous reply.

Sachin, when you move the definitions into the .c file per Tejun's
suggestion, please cleanup useless definitions.

Thanks and happy new year.
- Kukjin


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-01-04  2:25 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-31  5:29 [PATCH 1/1] ata: pata_samsung_cf: Move plat/regs-ata.h to drivers/ata Sachin Kamat
2013-12-31  6:32 ` Jingoo Han
2013-12-31 11:34 ` Tejun Heo
2014-01-02  0:49   ` Jingoo Han
2014-01-02  0:49     ` Jingoo Han
2014-01-04  2:25   ` kgene
2014-01-04  2:00 ` kgene

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.