All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/6] titanium: Return from cpu_eth_init() directly
Date: Sat,  4 Jan 2014 14:31:33 -0200	[thread overview]
Message-ID: <1388853097-3068-2-git-send-email-festevam@gmail.com> (raw)
In-Reply-To: <1388853097-3068-1-git-send-email-festevam@gmail.com>

From: Fabio Estevam <fabio.estevam@freescale.com>

There is no need to print an error message when cpu_eth_init() fails because
net/eth.c already prints it.

In order to simplify the code, just return the value from cpu_eth_init(bis)
directly.

Cc: Stefan Roese <sr@denx.de>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/barco/titanium/titanium.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/board/barco/titanium/titanium.c b/board/barco/titanium/titanium.c
index 6db4488..84a7b84 100644
--- a/board/barco/titanium/titanium.c
+++ b/board/barco/titanium/titanium.c
@@ -264,15 +264,9 @@ int board_phy_config(struct phy_device *phydev)
 
 int board_eth_init(bd_t *bis)
 {
-	int ret;
-
 	setup_iomux_enet();
 
-	ret = cpu_eth_init(bis);
-	if (ret)
-		printf("FEC MXC: %s:failed\n", __func__);
-
-	return ret;
+	return cpu_eth_init(bis);
 }
 
 int board_early_init_f(void)
-- 
1.8.1.2

  reply	other threads:[~2014-01-04 16:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-04 16:31 [U-Boot] [PATCH 1/6] wandboard: Return from cpu_eth_init() directly Fabio Estevam
2014-01-04 16:31 ` Fabio Estevam [this message]
2014-01-04 16:31 ` [U-Boot] [PATCH 3/6] mx6qarm2: Remove unneeded error message when cpu_eth_init() fails Fabio Estevam
2014-01-04 19:26   ` Wolfgang Denk
2014-01-04 19:39     ` Fabio Estevam
2014-01-04 16:31 ` [U-Boot] [PATCH 4/6] mx6qsabreauto: Return from cpu_eth_init() directly Fabio Estevam
2014-01-04 16:31 ` [U-Boot] [PATCH 5/6] mx6sabresd: " Fabio Estevam
2014-01-04 16:31 ` [U-Boot] [PATCH 6/6] mx6slevk: " Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1388853097-3068-2-git-send-email-festevam@gmail.com \
    --to=festevam@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.