All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: Julian Anastasov <ja@ssi.bg>,
	Bob Falken <NetFestivalHaveFun@gmx.com>,
	netdev@vger.kernel.org
Subject: Re: Multicast routing stops functioning after 4G multicast packets recived.
Date: Sun, 05 Jan 2014 11:12:17 -0800	[thread overview]
Message-ID: <1388949137.12212.166.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <20140105104145.GF25828@order.stressinduktion.org>

On Sun, 2014-01-05 at 11:41 +0100, Hannes Frederic Sowa wrote:
> On Sun, Jan 05, 2014 at 10:56:55AM +0200, Julian Anastasov wrote:
> > 
> > 	Hello,
> > 
> > On Sun, 5 Jan 2014, Hannes Frederic Sowa wrote:
> > 
> > > I guess we should just try. I somehow forgot to look after that. Thanks
> > > for reminding, Julian.
> > 
> > 	If that patch solves the problem, do not forget
> > to include same fix for ip6mr_fib_lookup(). As for net/decnet/,
> > it looks ok, it uses fib_rule_put() in dn_fib_res_put().
> 
> Thanks, I had IPv6 on my radar but did not check for other callers.

BTW, I wonder if the old kernels (2.6.32 & 2.6.34) need something as
well ?

Before commit ebc0ffae5dfb444 and commit 7fa7cb7109d0, it looks like we
had an overflow in fib_rule_get() and refcnt was wrapping.

So maybe we should add a fib_rule_put() for stable kernels, and use
FIB_LOOKUP_NOREF on next kernels ...

  reply	other threads:[~2014-01-05 19:12 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19 14:48 Multicast routing stops functioning after 4G multicast packets recived Bob Falken
2013-12-19 15:09 ` Hannes Frederic Sowa
2013-12-19 15:15   ` Ben Greear
2013-12-19 15:48     ` Hannes Frederic Sowa
2014-01-04 19:55 ` Julian Anastasov
2014-01-04 23:38   ` Hannes Frederic Sowa
2014-01-05  8:56     ` Julian Anastasov
2014-01-05 10:41       ` Hannes Frederic Sowa
2014-01-05 19:12         ` Eric Dumazet [this message]
2013-12-19 16:28 Bob Falken
2013-12-19 17:24 ` Eric Dumazet
2013-12-19 17:32   ` Hannes Frederic Sowa
2013-12-22  3:10   ` Hannes Frederic Sowa
2013-12-21 22:35 Bob Falken
2014-01-03  7:37 ` Hannes Frederic Sowa
2014-01-04 18:53 Bob Falken
2014-01-07 17:01 Bob Falken
2014-01-07 17:43 ` Hannes Frederic Sowa
2014-01-07 20:11   ` Hannes Frederic Sowa
2014-01-07 20:20     ` Hannes Frederic Sowa
2014-01-07 20:26     ` Eric Dumazet
2014-01-07 20:29       ` Hannes Frederic Sowa
2014-01-09 20:14 Bob Falken
2014-01-10  6:36 ` Hannes Frederic Sowa
2014-01-10  7:01   ` Eric Dumazet
2014-01-10  7:10     ` Hannes Frederic Sowa
2014-01-10  7:32       ` Eric Dumazet
2014-01-10  7:43         ` Hannes Frederic Sowa
2014-01-10  7:50           ` Hannes Frederic Sowa
2014-01-12  7:42             ` Hannes Frederic Sowa
2014-01-13  0:56               ` Eric Dumazet
2014-01-12  0:25 Bob Falken

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1388949137.12212.166.camel@edumazet-glaptop2.roam.corp.google.com \
    --to=eric.dumazet@gmail.com \
    --cc=NetFestivalHaveFun@gmx.com \
    --cc=hannes@stressinduktion.org \
    --cc=ja@ssi.bg \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.