From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 2/4] dbg_rw_guest_mem: Enable debug log
 output
Date: Mon, 6 Jan 2014 15:28:25 +0000
Message-ID: <1389022105.31766.54.camel@kazak.uk.xensource.com>
References: <1388857936-664-1-git-send-email-dslutz@verizon.com>
	<1388857936-664-3-git-send-email-dslutz@verizon.com>
	<20140104211319.GC9395@phenom.dumpdata.com>
	<52C87C1C.5080908@terremark.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <52C87C1C.5080908@terremark.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Don Slutz <dslutz@verizon.com>
Cc: Keir Fraser <keir@xen.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On Sat, 2014-01-04 at 16:24 -0500, Don Slutz wrote:
> On 01/04/14 16:13, Konrad Rzeszutek Wilk wrote:
> 
> > On Sat, Jan 04, 2014 at 12:52:14PM -0500, Don Slutz wrote:
> > > This also fixes the old debug output to compile and work if DBGP1
> > > and DBGP2 are defined like DBGP3.
> > > 
> > > @@ -226,3 +239,11 @@ dbg_rw_mem(dbgva_t addr, dbgbyte_t *buf, int len, domid_t domid, int toaddr,
> > >      return len;
> > >  }
> > >  
> > > +/*
> > > + * Local variables:
> > > + * mode: C
> > > + * c-file-style: "BSD"
> > > + * c-basic-offset: 4
> > > + * indent-tabs-mode: nil
> > > + * End:
> > > + */
> > ??
> 
> I take that as "Why add this"?
> 
> Dealing with many different styles of code, I find it helps to have
> this emacs add.

Yes, but why is it in the optional debug patch?