From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [BUGFIX][PATCH 4/4] XEN_DOMCTL_gdbsx_guestmemio: always do the copyback. Date: Mon, 6 Jan 2014 15:43:47 +0000 Message-ID: <1389023027.31766.63.camel@kazak.uk.xensource.com> References: <1388857936-664-1-git-send-email-dslutz@verizon.com> <1388857936-664-5-git-send-email-dslutz@verizon.com> <52C9EC3C.2060008@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <52C9EC3C.2060008@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Keir Fraser , Stefano Stabellini , George Dunlap , Ian Jackson , Don Slutz , xen-devel@lists.xen.org, Jan Beulich List-Id: xen-devel@lists.xenproject.org On Sun, 2014-01-05 at 23:35 +0000, Andrew Cooper wrote: > While this does change the ABI of a hypercall, I think it is > reasonable to do, as domctl.h does imply that 'remain' is an output > parameter, without specifying anything about its behaviour in the case > of an error. The domctl ABI is subject to change anyway. We don't seem to have had any cause to bump XEN_DOMCTL_INTERFACE_VERSION during the 4.4 dev cycle yet. I don't think this change warrants it either. Ian.