All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zoltan Kiss <zoltan.kiss@citrix.com>
To: <ian.campbell@citrix.com>, <wei.liu2@citrix.com>,
	<xen-devel@lists.xenproject.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <jonathan.davies@citrix.com>
Cc: Zoltan Kiss <zoltan.kiss@citrix.com>
Subject: [PATCH net-next v2 0/9] xen-netback: TX grant mapping with SKBTX_DEV_ZEROCOPY instead of copy
Date: Wed, 8 Jan 2014 00:10:09 +0000	[thread overview]
Message-ID: <1389139818-24458-1-git-send-email-zoltan.kiss@citrix.com> (raw)

A long known problem of the upstream netback implementation that on the TX
path (from guest to Dom0) it copies the whole packet from guest memory into
Dom0. That simply became a bottleneck with 10Gb NICs, and generally it's a
huge perfomance penalty. The classic kernel version of netback used grant
mapping, and to get notified when the page can be unmapped, it used page
destructors. Unfortunately that destructor is not an upstreamable solution.
Ian Campbell's skb fragment destructor patch series [1] tried to solve this
problem, however it seems to be very invasive on the network stack's code,
and therefore haven't progressed very well.
This patch series use SKBTX_DEV_ZEROCOPY flags to tell the stack it needs to
know when the skb is freed up. That is the way KVM solved the same problem,
and based on my initial tests it can do the same for us. Avoiding the extra
copy boosted up TX throughput from 6.8 Gbps to 7.9 (I used a slower
Interlagos box, both Dom0 and guest on upstream kernel, on the same NUMA node,
running iperf 2.0.5, and the remote end was a bare metal box on the same 10Gb
switch)
Based on my investigations the packet get only copied if it is delivered to
Dom0 stack, which is due to this [2] patch. That's a bit unfortunate, but
luckily it doesn't cause a major regression for this usecase. In the future
we should try to eliminate that copy somehow.
There are a few spinoff tasks which will be addressed in separate patches:
- grant copy the header directly instead of map and memcpy. This should help
  us avoiding TLB flushing
- use something else than ballooned pages
- fix grant map to use page->index properly
I will run some more extensive tests, but some basic XenRT tests were already
passed with good results.
I've tried to broke it down to smaller patches, with mixed results, so I
welcome suggestions on that part as well:
1: Introduce TX grant map definitions
2: Change TX path from grant copy to mapping
3: Remove old TX grant copy definitons and fix indentations
4: Change RX path for mapped SKB fragments
5: Add stat counters for zerocopy
6: Handle guests with too many frags
7: Add stat counters for frag_list skbs
8: Timeout packets in RX path
9: Aggregate TX unmap operations

v2: I've fixed some smaller things, see the individual patches. I've added a
few new stat counters, and handling the important use case when an older guest
sends lots of slots. Instead of delayed copy now we timeout packets on the RX
path, based on the assumption that otherwise packets should get stucked
anywhere else. Finally some unmap batching to avoid too much TLB flush

v3: Apart from fixing a few things mentioned in responses the important change
is the use the hypercall directly for grant [un]mapping, therefore we can
avoid m2p override.

[1] http://lwn.net/Articles/491522/
[2] https://lkml.org/lkml/2012/7/20/363

Signed-off-by: Zoltan Kiss <zoltan.kiss@citrix.com>


             reply	other threads:[~2014-01-08  0:10 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-08  0:10 Zoltan Kiss [this message]
2014-01-08  0:10 ` [PATCH net-next v3 1/9] xen-netback: Introduce TX grant map definitions Zoltan Kiss
2014-01-08  0:10 ` Zoltan Kiss
2014-01-08  1:29   ` David Miller
2014-01-08 14:08     ` Zoltan Kiss
2014-01-08 14:08     ` Zoltan Kiss
2014-01-08  1:29   ` David Miller
2014-01-09 15:30   ` Wei Liu
2014-01-09 15:30   ` Wei Liu
2014-01-09 15:42     ` David Vrabel
2014-01-09 15:42     ` David Vrabel
2014-01-09 17:28       ` Stefano Stabellini
2014-01-09 17:28       ` [Xen-devel] " Stefano Stabellini
2014-01-09 17:46         ` David Vrabel
2014-01-09 18:09           ` Stefano Stabellini
2014-01-09 18:23             ` David Vrabel
2014-01-09 18:23             ` David Vrabel
2014-01-09 18:09           ` Stefano Stabellini
2014-01-09 17:46         ` David Vrabel
2014-01-09 15:49     ` Roger Pau Monné
2014-01-09 15:49     ` Roger Pau Monné
2014-01-09 19:53     ` Zoltan Kiss
2014-01-09 19:53     ` Zoltan Kiss
2014-01-08  0:10 ` [PATCH net-next v3 2/9] xen-netback: Change TX path from grant copy to mapping Zoltan Kiss
2014-01-08  0:10   ` Zoltan Kiss
2014-01-09 15:30   ` Wei Liu
2014-01-09 15:30   ` Wei Liu
2014-01-10 11:35     ` Zoltan Kiss
2014-01-10 11:35     ` Zoltan Kiss
2014-01-10 11:45       ` Wei Liu
2014-01-10 11:45       ` Wei Liu
2014-01-10 13:16         ` Wei Liu
2014-01-10 13:16         ` Wei Liu
2014-01-10 15:24         ` Zoltan Kiss
2014-01-10 15:24         ` Zoltan Kiss
2014-01-10 16:02           ` David Vrabel
2014-01-10 16:02           ` [Xen-devel] " David Vrabel
2014-01-10 16:08             ` Wei Liu
2014-01-10 16:08             ` [Xen-devel] " Wei Liu
2014-01-12 23:19             ` Zoltan Kiss
2014-01-12 23:19             ` Zoltan Kiss
2014-01-08  0:10 ` [PATCH net-next v3 3/9] xen-netback: Remove old TX grant copy definitons and fix indentations Zoltan Kiss
2014-01-08  0:10 ` Zoltan Kiss
2014-01-08  0:10 ` [PATCH net-next v3 4/9] xen-netback: Change RX path for mapped SKB fragments Zoltan Kiss
2014-01-08  0:10   ` Zoltan Kiss
2014-01-08  0:10 ` [PATCH net-next v3 5/9] xen-netback: Add stat counters for zerocopy Zoltan Kiss
2014-01-08  0:10   ` Zoltan Kiss
2014-01-08  0:10 ` [PATCH net-next v3 6/9] xen-netback: Handle guests with too many frags Zoltan Kiss
2014-01-08  2:12   ` Eric Dumazet
2014-01-08 13:49     ` Zoltan Kiss
2014-01-08 13:49     ` Zoltan Kiss
2014-01-08 13:54       ` Eric Dumazet
2014-01-08 13:54       ` Eric Dumazet
2014-01-08 14:13         ` Zoltan Kiss
2014-01-08 14:13         ` Zoltan Kiss
2014-01-08  2:12   ` Eric Dumazet
2014-01-08  0:10 ` Zoltan Kiss
2014-01-08  0:10 ` [PATCH net-next v3 7/9] xen-netback: Add stat counters for frag_list skbs Zoltan Kiss
2014-01-08  0:10 ` Zoltan Kiss
2014-01-08  0:10 ` [PATCH net-next v3 8/9] xen-netback: Timeout packets in RX path Zoltan Kiss
2014-01-08  0:10 ` Zoltan Kiss
2014-01-08 21:34   ` Zoltan Kiss
2014-01-08 21:34   ` Zoltan Kiss
2014-01-09  9:20     ` Paul Durrant
2014-01-09  9:20     ` Paul Durrant
2014-01-13  0:20       ` Zoltan Kiss
2014-01-13  9:53         ` Paul Durrant
2014-01-13  9:53         ` Paul Durrant
2014-01-13  0:20       ` Zoltan Kiss
2014-01-08  0:10 ` [PATCH net-next v3 9/9] xen-netback: Aggregate TX unmap operations Zoltan Kiss
2014-01-08  0:10   ` Zoltan Kiss
2014-01-08  0:16 ` [PATCH net-next v2 0/9] xen-netback: TX grant mapping with SKBTX_DEV_ZEROCOPY instead of copy Zoltan Kiss
2014-01-08  0:16 ` Zoltan Kiss
2014-01-08 14:43 ` Wei Liu
2014-01-08 14:43 ` Wei Liu
2014-01-08 14:44   ` Zoltan Kiss
2014-01-08 14:44   ` Zoltan Kiss
  -- strict thread matches above, loose matches on Subject: below --
2014-01-08  0:10 Zoltan Kiss
2013-12-12 23:48 Zoltan Kiss
2013-12-12 23:48 Zoltan Kiss
2013-12-16  6:32 ` [Xen-devel] " annie li
2013-12-16 16:13   ` Zoltan Kiss
2013-12-16  6:32 ` annie li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1389139818-24458-1-git-send-email-zoltan.kiss@citrix.com \
    --to=zoltan.kiss@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=jonathan.davies@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.