All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: linux-kernel@vger.kernel.org
Cc: Wolfram Sang <wsa@the-dreams.de>, Felipe Balbi <balbi@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-omap@vger.kernel.org
Subject: [PATCH 5/7] drivers/usb/dwc3: don't check resource with devm_ioremap_resource
Date: Tue, 14 Jan 2014 12:58:56 +0100	[thread overview]
Message-ID: <1389700739-3696-5-git-send-email-wsa@the-dreams.de> (raw)
In-Reply-To: <1389700739-3696-1-git-send-email-wsa@the-dreams.de>

devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---

Should go via subsystem tree

 drivers/usb/dwc3/dwc3-omap.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index 7f7ea62..cbcd972 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb/dwc3/dwc3-omap.c
@@ -432,11 +432,6 @@ static int dwc3_omap_probe(struct platform_device *pdev)
 	}
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!res) {
-		dev_err(dev, "missing memory base resource\n");
-		return -EINVAL;
-	}
-
 	base = devm_ioremap_resource(dev, res);
 	if (IS_ERR(base))
 		return PTR_ERR(base);
-- 
1.8.5.1


  parent reply	other threads:[~2014-01-14 12:00 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-14 11:58 [PATCH 1/7] arch/mips/lantiq/xway: " Wolfram Sang
     [not found] ` <1389700739-3696-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-01-14 11:58   ` [PATCH 2/7] drivers/amba: " Wolfram Sang
2014-01-14 11:58 ` Wolfram Sang
2014-01-14 13:32   ` Thierry Reding
2014-01-14 17:40   ` Stephen Warren
2014-01-14 18:30     ` Wolfram Sang
     [not found]     ` <52D57688.8070105-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-01-14 18:30       ` Wolfram Sang
2014-02-05 17:18   ` Stephen Warren
     [not found]   ` <1389700739-3696-2-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-01-14 13:32     ` Thierry Reding
2014-01-14 17:40     ` Stephen Warren
2014-02-05 17:18     ` Stephen Warren
2014-01-14 11:58 ` [PATCH 3/7] drivers/gpu/host1x/drm: " Wolfram Sang
2014-01-14 13:40   ` Thierry Reding
     [not found]   ` <1389700739-3696-3-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-01-14 13:40     ` Thierry Reding
2014-01-14 11:58 ` [PATCH 4/7] drivers/pci/host: " Wolfram Sang
2014-01-14 13:17   ` Marek Vasut
2014-01-14 22:32     ` Jingoo Han
2014-01-14 11:58 ` Wolfram Sang [this message]
     [not found]   ` <1389700739-3696-5-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-01-14 14:15     ` [PATCH 5/7] drivers/usb/dwc3: " Felipe Balbi
2014-01-14 14:15   ` Felipe Balbi
2014-01-14 11:58 ` [PATCH 6/7] arch/mips/pci: " Wolfram Sang
2014-01-14 11:58 ` [PATCH 7/7] drivers/gpio: " Wolfram Sang
2014-01-15  9:28   ` Linus Walleij
2014-01-15 12:54     ` Sekhar Nori
2014-01-15 13:51       ` Linus Walleij
2014-01-15 14:04         ` Sekhar Nori
2014-01-15 15:50           ` Kevin Hilman
2014-01-16  4:29             ` Sekhar Nori
2014-02-03 11:30               ` Grygorii Strashko
2014-01-14 12:03 ` [PATCH 1/7] arch/mips/lantiq/xway: " John Crispin
2014-01-14 12:11   ` Wolfram Sang
2014-01-14 12:22     ` John Crispin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1389700739-3696-5-git-send-email-wsa@the-dreams.de \
    --to=wsa@the-dreams.de \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --subject='Re: [PATCH 5/7] drivers/usb/dwc3: don'\''t check resource with devm_ioremap_resource' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.