From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93521C433DB for ; Mon, 22 Mar 2021 16:25:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61EA26197F for ; Mon, 22 Mar 2021 16:25:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231373AbhCVQZN (ORCPT ); Mon, 22 Mar 2021 12:25:13 -0400 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:40732 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231310AbhCVQYn (ORCPT ); Mon, 22 Mar 2021 12:24:43 -0400 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12MGKlFV018645; Mon, 22 Mar 2021 17:23:46 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=S7RCTHzi534pxE4KMJqypcbpIdoTSLI6H/XMtQDWVHU=; b=euJe7z5u5KAejDrba1xiC2QFGmeiI7ze9JJIZbWiBx1wGFh9CDj2+3uiP4mDB/PpeGty LIphGyAFTQs87VPvNQe/sPU38ZDlZNohNxeeEgw6x88eRNgvO8GvV147+M1qtwaff9fv OG5kIywmH7Fr0Ynzm+UlPt5zkHtEWBv0xBYMSCsPtnlYH9pf33gQV1JsbN4fTsO3SYbs uSRNMzKysR+Qy7/3WKmsrGbPdfIbx7NS0fJhNGJbK1WzPOTEWXOc0xGRaS1BTi6Rtr1e f+Z2Zi4dF6j7fiMVdardjeyeWPL2KHObioJeGWLA+xznkMdM99ZUUHWzOhx3h+hvbtJ3 9w== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 37d996acwq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Mar 2021 17:23:46 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 73B8B10002A; Mon, 22 Mar 2021 17:23:46 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 5F17F22A2A3; Mon, 22 Mar 2021 17:23:46 +0100 (CET) Received: from [10.211.8.180] (10.75.127.50) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 22 Mar 2021 17:23:44 +0100 Subject: Re: [Linux-stm32] [PATCH v10 16/33] counter: stm32-lptimer-cnt: Add const qualifier for actions_list array To: William Breathitt Gray , CC: , , , , , , , , , , Fabrice Gasnier , , , , References: <1a454675b256daed71e0c0053377f36475f920d3.1616150619.git.vilhelm.gray@gmail.com> From: Fabrice Gasnier Message-ID: <138989da-a4da-237e-8a42-d0f746768d95@foss.st.com> Date: Mon, 22 Mar 2021 17:23:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1a454675b256daed71e0c0053377f36475f920d3.1616150619.git.vilhelm.gray@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.50] X-ClientProxiedBy: SFHDAG2NODE1.st.com (10.75.127.4) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-03-22_08:2021-03-22,2021-03-22 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/19/21 12:00 PM, William Breathitt Gray wrote: > The struct counter_synapse actions_list member expects a const enum > counter_synapse_action array. This patch adds the const qualifier to the > stm32_lptim_cnt_synapse_actions to match actions_list. > > Cc: Fabrice Gasnier > Signed-off-by: William Breathitt Gray > --- > drivers/counter/stm32-lptimer-cnt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hi William, You can add my: Reviewed-by: Fabrice Gasnier Thanks, Fabrice > > diff --git a/drivers/counter/stm32-lptimer-cnt.c b/drivers/counter/stm32-lptimer-cnt.c > index 0f7d3f1ec1b6..c19d998df5ba 100644 > --- a/drivers/counter/stm32-lptimer-cnt.c > +++ b/drivers/counter/stm32-lptimer-cnt.c > @@ -146,7 +146,7 @@ enum stm32_lptim_synapse_action { > STM32_LPTIM_SYNAPSE_ACTION_NONE, > }; > > -static enum counter_synapse_action stm32_lptim_cnt_synapse_actions[] = { > +static const enum counter_synapse_action stm32_lptim_cnt_synapse_actions[] = { > /* Index must match with stm32_lptim_cnt_polarity[] (priv->polarity) */ > [STM32_LPTIM_SYNAPSE_ACTION_RISING_EDGE] = COUNTER_SYNAPSE_ACTION_RISING_EDGE, > [STM32_LPTIM_SYNAPSE_ACTION_FALLING_EDGE] = COUNTER_SYNAPSE_ACTION_FALLING_EDGE, > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6586DC433C1 for ; Mon, 22 Mar 2021 16:26:51 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F3976044F for ; Mon, 22 Mar 2021 16:26:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F3976044F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=R+CS9MlpnFmLhws2sRrREKqUCBTOewTJX9n10AgUA98=; b=c6ccd4/yY1wteTyPE9UWLzYIX BQK6874fMikCyOKiKZ5Oh1Cml2Z3XBjPYsN2WtIn7vUjzbkfT0bqBF5nuU2x5j23LZtHEi0UodzHT K+NveeOb9vHVL1zPir2z9xfQdbMrjRwvjA6fM4NgBLUGzSTSozxkhSB9rs79xgy96eZIqUdtf2bHT VTdhj6Uttr80xbQeQRjOCmyaLyRq5h2tsz65f6hEQ3XSia/7CnpLfkzJCZd7VJO+1Em3mBA9SMGPp AFH1rfFHlrc8LAbnVFpMlAZd2S+ST6mIuc8qBNjBRkOTb06mWtarhnmavP2w6WVdoo+WyqD6Y5mQF zTwHuxPKw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lONMB-00C1AG-Sq; Mon, 22 Mar 2021 16:24:44 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lONM6-00C19S-TL for linux-arm-kernel@lists.infradead.org; Mon, 22 Mar 2021 16:24:40 +0000 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12MGKlFV018645; Mon, 22 Mar 2021 17:23:46 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=S7RCTHzi534pxE4KMJqypcbpIdoTSLI6H/XMtQDWVHU=; b=euJe7z5u5KAejDrba1xiC2QFGmeiI7ze9JJIZbWiBx1wGFh9CDj2+3uiP4mDB/PpeGty LIphGyAFTQs87VPvNQe/sPU38ZDlZNohNxeeEgw6x88eRNgvO8GvV147+M1qtwaff9fv OG5kIywmH7Fr0Ynzm+UlPt5zkHtEWBv0xBYMSCsPtnlYH9pf33gQV1JsbN4fTsO3SYbs uSRNMzKysR+Qy7/3WKmsrGbPdfIbx7NS0fJhNGJbK1WzPOTEWXOc0xGRaS1BTi6Rtr1e f+Z2Zi4dF6j7fiMVdardjeyeWPL2KHObioJeGWLA+xznkMdM99ZUUHWzOhx3h+hvbtJ3 9w== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 37d996acwq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Mar 2021 17:23:46 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 73B8B10002A; Mon, 22 Mar 2021 17:23:46 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 5F17F22A2A3; Mon, 22 Mar 2021 17:23:46 +0100 (CET) Received: from [10.211.8.180] (10.75.127.50) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 22 Mar 2021 17:23:44 +0100 Subject: Re: [Linux-stm32] [PATCH v10 16/33] counter: stm32-lptimer-cnt: Add const qualifier for actions_list array To: William Breathitt Gray , CC: , , , , , , , , , , Fabrice Gasnier , , , , References: <1a454675b256daed71e0c0053377f36475f920d3.1616150619.git.vilhelm.gray@gmail.com> From: Fabrice Gasnier Message-ID: <138989da-a4da-237e-8a42-d0f746768d95@foss.st.com> Date: Mon, 22 Mar 2021 17:23:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1a454675b256daed71e0c0053377f36475f920d3.1616150619.git.vilhelm.gray@gmail.com> Content-Language: en-US X-Originating-IP: [10.75.127.50] X-ClientProxiedBy: SFHDAG2NODE1.st.com (10.75.127.4) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-22_08:2021-03-22, 2021-03-22 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210322_162439_112080_C7427FFA X-CRM114-Status: GOOD ( 19.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/19/21 12:00 PM, William Breathitt Gray wrote: > The struct counter_synapse actions_list member expects a const enum > counter_synapse_action array. This patch adds the const qualifier to the > stm32_lptim_cnt_synapse_actions to match actions_list. > > Cc: Fabrice Gasnier > Signed-off-by: William Breathitt Gray > --- > drivers/counter/stm32-lptimer-cnt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hi William, You can add my: Reviewed-by: Fabrice Gasnier Thanks, Fabrice > > diff --git a/drivers/counter/stm32-lptimer-cnt.c b/drivers/counter/stm32-lptimer-cnt.c > index 0f7d3f1ec1b6..c19d998df5ba 100644 > --- a/drivers/counter/stm32-lptimer-cnt.c > +++ b/drivers/counter/stm32-lptimer-cnt.c > @@ -146,7 +146,7 @@ enum stm32_lptim_synapse_action { > STM32_LPTIM_SYNAPSE_ACTION_NONE, > }; > > -static enum counter_synapse_action stm32_lptim_cnt_synapse_actions[] = { > +static const enum counter_synapse_action stm32_lptim_cnt_synapse_actions[] = { > /* Index must match with stm32_lptim_cnt_polarity[] (priv->polarity) */ > [STM32_LPTIM_SYNAPSE_ACTION_RISING_EDGE] = COUNTER_SYNAPSE_ACTION_RISING_EDGE, > [STM32_LPTIM_SYNAPSE_ACTION_FALLING_EDGE] = COUNTER_SYNAPSE_ACTION_FALLING_EDGE, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel