All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Jim Fehlig <jfehlig@suse.com>, xen-devel@lists.xensource.com
Subject: Re: [PATCH 2/3] xl: Free optdata_begin when saving domain config
Date: Mon, 20 Jan 2014 09:41:48 +0000	[thread overview]
Message-ID: <1390210908.20516.2.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <1389980090-3479-3-git-send-email-ian.jackson@eu.citrix.com>

On Fri, 2014-01-17 at 17:34 +0000, Ian Jackson wrote:
> This makes valgrind a bit happier.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Ian Campbell <Ian.Campbell@citrix.com>

> ---
>  tools/libxl/xl_cmdimpl.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index d93e01b..aff6f90 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -3442,6 +3442,8 @@ static void save_domain_core_writeconfig(int fd, const char *source,
>                       ctx, fd, optdata_begin, hdr.optional_data_len,
>                       source, "header"));
>  
> +    free(optdata_begin);
> +
>      fprintf(stderr, "Saving to %s new xl format (info"
>              " 0x%"PRIx32"/0x%"PRIx32"/%"PRIu32")\n",
>              source, hdr.mandatory_flags, hdr.optional_flags,

  parent reply	other threads:[~2014-01-20  9:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-17 17:34 [PATCH 0/3] tools: Miscellanous fixes for 4.4 Ian Jackson
2014-01-17 17:34 ` [PATCH 1/3] libxl: events: Pass correct nfds to poll Ian Jackson
2014-01-20  9:41   ` Ian Campbell
2014-01-17 17:34 ` [PATCH 2/3] xl: Free optdata_begin when saving domain config Ian Jackson
2014-01-17 17:43   ` Andrew Cooper
2014-01-20  9:41   ` Ian Campbell [this message]
2014-01-17 17:34 ` [PATCH 3/3] xenstore: xs_suspend_evtchn_port: always free portstr Ian Jackson
2014-01-17 17:46   ` Andrew Cooper
2014-01-20  9:42   ` Ian Campbell
2014-01-21 18:45 [PATCH v2 0/3] tools: Fixes for 4.4 Ian Jackson
2014-01-21 18:45 ` [PATCH 2/3] xl: Free optdata_begin when saving domain config Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390210908.20516.2.camel@kazak.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jfehlig@suse.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.