From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1blp0187.outbound.protection.outlook.com [207.46.163.187]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id BE20D2C00A3 for ; Tue, 21 Jan 2014 05:30:17 +1100 (EST) Message-ID: <1390242603.24905.297.camel@snotra.buserror.net> Subject: Re: [PATCH] powerpc: 85xx: EDAC PCI: request irq as IRQF_SHARED From: Scott Wood To: Tiejun Chen Date: Mon, 20 Jan 2014 12:30:03 -0600 In-Reply-To: <1390207175-2181-2-git-send-email-tiejun.chen@windriver.com> References: <1390207175-2181-1-git-send-email-tiejun.chen@windriver.com> <1390207175-2181-2-git-send-email-tiejun.chen@windriver.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Cc: linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2014-01-20 at 16:39 +0800, Tiejun Chen wrote: > AER driver needs to share this PCI err irq with EDAC, otherwise > we can't register AER driver successfully as follows: > > genirq: Flags mismatch irq 482. 00000080 (aerdrv) vs. 00000020 ([EDAC] PCI err) > CPU: 3 PID: 1 Comm: swapper/0 Not tainted 3.13.0-rc1-148346-g2513817 #69 > Call Trace: > [ee063cb0] [c00070c4] show_stack+0x44/0x160 (unreliable) > [ee063cf0] [c055fac4] dump_stack+0x78/0xa0 > [ee063d00] [c006e16c] __setup_irq+0x51c/0x540 > [ee063d40] [c006e264] request_threaded_irq+0xd4/0x150 > [ee063d70] [c0280d10] aer_probe+0xe0/0x2a0 > [ee063da0] [c027e590] pcie_port_probe_service+0x40/0x90 > [ee063dc0] [c02c253c] driver_probe_device+0x8c/0x250 > [ee063de0] [c02c27bc] __driver_attach+0xbc/0xc0 > [ee063e00] [c02c0760] bus_for_each_dev+0x70/0xb0 > [ee063e30] [c02c1f94] driver_attach+0x24/0x40 > [ee063e40] [c02c1aec] bus_add_driver+0xfc/0x210 > [ee063e60] [c02c2d98] driver_register+0x88/0x140 > [ee063e70] [c027e4b4] pcie_port_service_register+0x64/0x80 > [ee063e80] [c06fb14c] aer_service_init+0x28/0x38 > [ee063e90] [c0002468] do_one_initcall+0x158/0x1b0 > [ee063f00] [c06e291c] kernel_init_freeable+0x128/0x1d4 > [ee063f30] [c0002ac4] kernel_init+0x14/0x130 > [ee063f40] [c000f84c] ret_from_kernel_thread+0x5c/0x64 > aer: probe of 0000:00:00.0:pcie02 failed with error -16 > genirq: Flags mismatch irq 480. 00000080 (aerdrv) vs. 00000020 ([EDAC] PCI err) > CPU: 3 PID: 1 Comm: swapper/0 Not tainted 3.13.0-rc1-148346-g2513817 #69 > Call Trace: > [ee063cb0] [c00070c4] show_stack+0x44/0x160 (unreliable) > [ee063cf0] [c055fac4] dump_stack+0x78/0xa0 > [ee063d00] [c006e16c] __setup_irq+0x51c/0x540 > [ee063d40] [c006e264] request_threaded_irq+0xd4/0x150 > [ee063d70] [c0280d10] aer_probe+0xe0/0x2a0 > [ee063da0] [c027e590] pcie_port_probe_service+0x40/0x90 > [ee063dc0] [c02c253c] driver_probe_device+0x8c/0x250 > [ee063de0] [c02c27bc] __driver_attach+0xbc/0xc0 > [ee063e00] [c02c0760] bus_for_each_dev+0x70/0xb0 > [ee063e30] [c02c1f94] driver_attach+0x24/0x40 > [ee063e40] [c02c1aec] bus_add_driver+0xfc/0x210 > [ee063e60] [c02c2d98] driver_register+0x88/0x140 > [ee063e70] [c027e4b4] pcie_port_service_register+0x64/0x80 > [ee063e80] [c06fb14c] aer_service_init+0x28/0x38 > [ee063e90] [c0002468] do_one_initcall+0x158/0x1b0 > [ee063f00] [c06e291c] kernel_init_freeable+0x128/0x1d4 > [ee063f30] [c0002ac4] kernel_init+0x14/0x130 > [ee063f40] [c000f84c] ret_from_kernel_thread+0x5c/0x64 > aer: probe of 0001:02:00.0:pcie02 failed with error -16 > > Signed-off-by: Tiejun Chen > --- > drivers/edac/mpc85xx_edac.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) This patch should be sent to the maintainer and list specified under EDAC-MPC85XX. > diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c > index fd46b0b..0dda7c4 100644 > --- a/drivers/edac/mpc85xx_edac.c > +++ b/drivers/edac/mpc85xx_edac.c > @@ -297,7 +297,8 @@ int mpc85xx_pci_err_probe(struct platform_device *op) > if (edac_op_state == EDAC_OPSTATE_INT) { > pdata->irq = irq_of_parse_and_map(op->dev.of_node, 0); > res = devm_request_irq(&op->dev, pdata->irq, > - mpc85xx_pci_isr, IRQF_DISABLED, > + mpc85xx_pci_isr, IRQF_SHARED | > + IRQF_DISABLED, > "[EDAC] PCI err", pci); > if (res < 0) { > printk(KERN_ERR While you're touching this, perhaps remove IRQF_DISABLED which is a deprecated no-op and will eventually be removed. -Scott