All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-media@vger.kernel.org
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
	Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH 26/47] v4l: Improve readability by not wrapping ioctl number #define's
Date: Wed,  5 Feb 2014 17:42:17 +0100	[thread overview]
Message-ID: <1391618558-5580-27-git-send-email-laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <1391618558-5580-1-git-send-email-laurent.pinchart@ideasonboard.com>

Wrapping the #define's at a 80 columns boundary just obfuscates the
code. Don't do that.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 include/uapi/linux/v4l2-subdev.h | 33 +++++++++++++--------------------
 1 file changed, 13 insertions(+), 20 deletions(-)

diff --git a/include/uapi/linux/v4l2-subdev.h b/include/uapi/linux/v4l2-subdev.h
index a33c4da..9fe3493 100644
--- a/include/uapi/linux/v4l2-subdev.h
+++ b/include/uapi/linux/v4l2-subdev.h
@@ -156,25 +156,18 @@ struct v4l2_subdev_edid {
 	__u8 __user *edid;
 };
 
-#define VIDIOC_SUBDEV_G_FMT	_IOWR('V',  4, struct v4l2_subdev_format)
-#define VIDIOC_SUBDEV_S_FMT	_IOWR('V',  5, struct v4l2_subdev_format)
-#define VIDIOC_SUBDEV_G_FRAME_INTERVAL \
-			_IOWR('V', 21, struct v4l2_subdev_frame_interval)
-#define VIDIOC_SUBDEV_S_FRAME_INTERVAL \
-			_IOWR('V', 22, struct v4l2_subdev_frame_interval)
-#define VIDIOC_SUBDEV_ENUM_MBUS_CODE \
-			_IOWR('V',  2, struct v4l2_subdev_mbus_code_enum)
-#define VIDIOC_SUBDEV_ENUM_FRAME_SIZE \
-			_IOWR('V', 74, struct v4l2_subdev_frame_size_enum)
-#define VIDIOC_SUBDEV_ENUM_FRAME_INTERVAL \
-			_IOWR('V', 75, struct v4l2_subdev_frame_interval_enum)
-#define VIDIOC_SUBDEV_G_CROP	_IOWR('V', 59, struct v4l2_subdev_crop)
-#define VIDIOC_SUBDEV_S_CROP	_IOWR('V', 60, struct v4l2_subdev_crop)
-#define VIDIOC_SUBDEV_G_SELECTION \
-	_IOWR('V', 61, struct v4l2_subdev_selection)
-#define VIDIOC_SUBDEV_S_SELECTION \
-	_IOWR('V', 62, struct v4l2_subdev_selection)
-#define VIDIOC_SUBDEV_G_EDID	_IOWR('V', 40, struct v4l2_subdev_edid)
-#define VIDIOC_SUBDEV_S_EDID	_IOWR('V', 41, struct v4l2_subdev_edid)
+#define VIDIOC_SUBDEV_G_FMT			_IOWR('V',  4, struct v4l2_subdev_format)
+#define VIDIOC_SUBDEV_S_FMT			_IOWR('V',  5, struct v4l2_subdev_format)
+#define VIDIOC_SUBDEV_G_FRAME_INTERVAL		_IOWR('V', 21, struct v4l2_subdev_frame_interval)
+#define VIDIOC_SUBDEV_S_FRAME_INTERVAL		_IOWR('V', 22, struct v4l2_subdev_frame_interval)
+#define VIDIOC_SUBDEV_ENUM_MBUS_CODE		_IOWR('V',  2, struct v4l2_subdev_mbus_code_enum)
+#define VIDIOC_SUBDEV_ENUM_FRAME_SIZE		_IOWR('V', 74, struct v4l2_subdev_frame_size_enum)
+#define VIDIOC_SUBDEV_ENUM_FRAME_INTERVAL	_IOWR('V', 75, struct v4l2_subdev_frame_interval_enum)
+#define VIDIOC_SUBDEV_G_CROP			_IOWR('V', 59, struct v4l2_subdev_crop)
+#define VIDIOC_SUBDEV_S_CROP			_IOWR('V', 60, struct v4l2_subdev_crop)
+#define VIDIOC_SUBDEV_G_SELECTION		_IOWR('V', 61, struct v4l2_subdev_selection)
+#define VIDIOC_SUBDEV_S_SELECTION		_IOWR('V', 62, struct v4l2_subdev_selection)
+#define VIDIOC_SUBDEV_G_EDID			_IOWR('V', 40, struct v4l2_subdev_edid)
+#define VIDIOC_SUBDEV_S_EDID			_IOWR('V', 41, struct v4l2_subdev_edid)
 
 #endif
-- 
1.8.3.2


  parent reply	other threads:[~2014-02-05 16:41 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-05 16:41 [PATCH 00/47] ADV7611 support Laurent Pinchart
2014-02-05 16:41 ` [PATCH 01/47] v4l: of: Support empty port nodes Laurent Pinchart
2014-02-05 16:41 ` [PATCH 02/47] v4l: Add UYVY10_2X10 and VYUY10_2X10 media bus pixel codes Laurent Pinchart
2014-02-05 16:41 ` [PATCH 03/47] v4l: Add UYVY10_1X20 and VYUY10_1X20 " Laurent Pinchart
2014-02-05 16:41 ` [PATCH 04/47] v4l: Add 12-bit YUV 4:2:0 " Laurent Pinchart
2014-02-05 16:41 ` [PATCH 05/47] v4l: Add 12-bit YUV 4:2:2 " Laurent Pinchart
2014-02-05 16:41 ` [PATCH 06/47] v4l: Add pad-level DV timings subdev operations Laurent Pinchart
2014-02-05 17:13   ` Hans Verkuil
2014-02-06 17:33   ` Sakari Ailus
2014-02-07  0:50     ` Laurent Pinchart
2014-02-05 16:41 ` [PATCH 07/47] ad9389b: Add pad-level DV timings operations Laurent Pinchart
2014-02-05 16:41 ` [PATCH 08/47] adv7511: " Laurent Pinchart
2014-02-05 16:42 ` [PATCH 09/47] adv7842: " Laurent Pinchart
2014-02-05 16:42 ` [PATCH 10/47] s5p-tv: hdmi: " Laurent Pinchart
2014-02-05 16:42 ` [PATCH 11/47] s5p-tv: hdmiphy: " Laurent Pinchart
2014-02-05 16:42 ` [PATCH 12/47] ths8200: " Laurent Pinchart
2014-02-05 16:42 ` [PATCH 13/47] tvp7002: " Laurent Pinchart
2014-02-05 16:42 ` [PATCH 14/47] media: bfin_capture: Switch to pad-level DV operations Laurent Pinchart
2014-02-05 16:42 ` [PATCH 15/47] media: davinci: vpif: " Laurent Pinchart
2014-02-05 16:42 ` [PATCH 16/47] media: staging: davinci: vpfe: " Laurent Pinchart
2014-02-05 16:42 ` [PATCH 17/47] s5p-tv: mixer: " Laurent Pinchart
2014-02-05 16:42 ` [PATCH 18/47] ad9389b: Remove deprecated video-level DV timings operations Laurent Pinchart
2014-02-05 16:42 ` [PATCH 19/47] adv7511: " Laurent Pinchart
2014-02-05 16:42 ` [PATCH 20/47] adv7842: " Laurent Pinchart
2014-02-05 16:42 ` [PATCH 21/47] s5p-tv: hdmi: " Laurent Pinchart
2014-02-05 16:42 ` [PATCH 22/47] s5p-tv: hdmiphy: Remove deprecated video-level DV timings operation Laurent Pinchart
2014-02-05 16:42 ` [PATCH 23/47] ths8200: Remove deprecated video-level DV timings operations Laurent Pinchart
2014-02-05 16:42 ` [PATCH 24/47] tvp7002: " Laurent Pinchart
2014-02-05 16:42 ` [PATCH 25/47] v4l: subdev: " Laurent Pinchart
2014-02-06 17:35   ` Sakari Ailus
2014-02-12 12:48   ` Hans Verkuil
2014-02-05 16:42 ` Laurent Pinchart [this message]
2014-02-06 17:34   ` [PATCH 26/47] v4l: Improve readability by not wrapping ioctl number #define's Sakari Ailus
2014-02-05 16:42 ` [PATCH 27/47] v4l: Add support for DV timings ioctls on subdev nodes Laurent Pinchart
2014-02-05 17:31   ` Hans Verkuil
2014-02-07  1:21     ` Laurent Pinchart
2014-02-07 11:07   ` Sakari Ailus
2014-02-10 12:53     ` Laurent Pinchart
2014-02-05 16:42 ` [PATCH 28/47] adv7604: Add missing include to linux/types.h Laurent Pinchart
2014-02-05 16:42 ` [PATCH 29/47] adv7604: Add support for asynchronous probing Laurent Pinchart
2014-02-05 16:42 ` [PATCH 30/47] adv7604: Don't put info string arrays on the stack Laurent Pinchart
2014-02-05 16:42 ` [PATCH 31/47] adv7604: Add 16-bit read functions for CP and HDMI Laurent Pinchart
2014-02-05 16:42 ` [PATCH 32/47] adv7604: Cache register contents when reading multiple bits Laurent Pinchart
2014-02-05 16:42 ` [PATCH 33/47] adv7604: Add adv7611 support Laurent Pinchart
2014-02-05 16:42 ` [PATCH 34/47] adv7604: Remove subdev control handlers Laurent Pinchart
2014-02-05 16:42 ` [PATCH 35/47] adv7604: Add sink pads Laurent Pinchart
2014-02-11 10:19   ` Hans Verkuil
2014-02-11 12:00     ` Laurent Pinchart
2014-02-11 12:07       ` Hans Verkuil
2014-02-11 12:23         ` Laurent Pinchart
2014-02-11 12:24           ` Hans Verkuil
2014-02-11 12:32             ` Laurent Pinchart
2014-02-11 12:33               ` Hans Verkuil
2014-02-05 16:42 ` [PATCH 36/47] adv7604: Make output format configurable through pad format operations Laurent Pinchart
2014-02-12 15:01   ` Hans Verkuil
2014-03-10 22:43     ` Laurent Pinchart
2014-03-11  9:05       ` Hans Verkuil
2014-03-11 11:16         ` Laurent Pinchart
2014-03-11 11:29           ` Hans Verkuil
2014-02-05 16:42 ` [PATCH 37/47] adv7604: Add pad-level DV timings support Laurent Pinchart
2014-02-05 16:42 ` [PATCH 38/47] adv7604: Remove deprecated video-level DV timings operations Laurent Pinchart
2014-02-05 16:42 ` [PATCH 39/47] adv7604: Inline the to_sd function Laurent Pinchart
2014-02-05 16:42 ` [PATCH 40/47] adv7604: Store I2C addresses and clients in arrays Laurent Pinchart
2014-02-05 16:42 ` [PATCH 41/47] adv7604: Replace *_and_or() functions with *_clr_set() Laurent Pinchart
2014-02-05 16:42 ` [PATCH 42/47] adv7604: Sort headers alphabetically Laurent Pinchart
2014-02-05 16:42 ` [PATCH 43/47] adv7604: Control hot-plug detect through a GPIO Laurent Pinchart
2014-02-06 13:10   ` Lars-Peter Clausen
2014-02-10 15:00     ` Laurent Pinchart
2014-02-11 10:09   ` Hans Verkuil
2014-02-11 12:03     ` Laurent Pinchart
2014-02-13  9:47       ` Hans Verkuil
2014-02-13 10:10         ` Lars-Peter Clausen
2014-02-13 14:33         ` Laurent Pinchart
2014-02-05 16:42 ` [PATCH 44/47] adv7604: Specify the default input through platform data Laurent Pinchart
2014-02-05 16:42 ` [PATCH 45/47] adv7604: Add DT support Laurent Pinchart
2014-02-11  9:23   ` Hans Verkuil
2014-02-11 12:08     ` Laurent Pinchart
2014-02-11 12:14       ` Hans Verkuil
2014-02-11 12:21         ` Lars-Peter Clausen
2014-02-11 12:30           ` Laurent Pinchart
2014-02-05 16:42 ` [PATCH 46/47] adv7604: Add LLC polarity configuration Laurent Pinchart
2014-02-05 16:42 ` [PATCH 47/47] adv7604: Add endpoint properties to DT bindings Laurent Pinchart
2014-02-05 17:12 ` [PATCH 00/47] ADV7611 support Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391618558-5580-27-git-send-email-laurent.pinchart@ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=hans.verkuil@cisco.com \
    --cc=lars@metafoo.de \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.