From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] tools/gdbsx: define format strings for aarch64 Date: Fri, 7 Feb 2014 10:08:50 +0000 Message-ID: <1391767730.2162.23.camel@kazak.uk.xensource.com> References: <1391329191-22566-1-git-send-email-olaf@aepfle.de> <1391336650.15093.23.camel@hastur.hellion.org.uk> <20140202102852.GA9984@aepfle.de> <1391337376.15093.24.camel@hastur.hellion.org.uk> <20140206171248.5143e7b3@mantra.us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140206171248.5143e7b3@mantra.us.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Mukesh Rathor Cc: Olaf Hering , Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, 2014-02-06 at 17:12 -0800, Mukesh Rathor wrote: > On Sun, 2 Feb 2014 10:36:16 +0000 > Ian Campbell wrote: > > > On Sun, 2014-02-02 at 11:28 +0100, Olaf Hering wrote: > > > On Sun, Feb 02, Ian Campbell wrote: > > > > > > > I suppose there is no harm in this, but is there any chance that > > > > gdbsx would actually work on arm64 without significant actual > > > > work going into it? > > > > > > I have no idea. But I just noticed its built only due to this line > > > in our xen.spec: > > > > > > make -C tools/debugger/gdbsx > > > > > > Perhaps this should be guarded by a %ifarch x86_64. > > > > I suspect that right now that this would be wise (maybe i386 too?) -- > > hopefully Mukesh can advise. > > > > Ian. > > It should just work if you can quickly implement > arch/x86/debug.c for arm. Thanks. Looks like we'd also need to make a bunch of arch/x86/domctl.c generic too, or implement the appropriate arm equivalents. Not a 4.4 thing for sure, if someone wants gdbsx on arm then patches for 4.5 would be welcome as always. > If not, you'd need to "arch it out". > > thanks > mukesh