From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDz3i-0000Jl-MJ for qemu-devel@nongnu.org; Thu, 13 Feb 2014 11:22:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDz3c-0000tl-NI for qemu-devel@nongnu.org; Thu, 13 Feb 2014 11:22:42 -0500 Received: from paradis.irqsave.net ([62.212.105.220]:49942) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDz3c-0000tE-Dw for qemu-devel@nongnu.org; Thu, 13 Feb 2014 11:22:36 -0500 From: =?UTF-8?q?Beno=C3=AEt=20Canet?= Date: Thu, 13 Feb 2014 17:22:32 +0100 Message-Id: <1392308553-9886-1-git-send-email-benoit.canet@irqsave.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH] Fix: remove bogus QDECREF() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, =?UTF-8?q?Beno=C3=AEt=20Canet?= This extra QDECREF() was causing quorum_close() to crash while doing bdrv_unref(). As the optional options qdict should belong to the block layer so do not = use QDECREF() on it. I tested the following inti and qemu exit sequences. tested regular snapshots on device=3Dvirtio0 ok tested command line quorum ok tested command line quorum + snapshot transaction ok tested quorum open by reference ok tested quorum open by reference + snapshot transaction ok tested quorum open at once ok tested quorum open at once + snapshot transaction ok Beno=C3=AEt Canet (1): blockdev: Fix wrong usage of QDECREF causing snapshoted quorum to crash on close. blockdev.c | 2 -- 1 file changed, 2 deletions(-) --=20 1.8.3.2