From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbaBNIRa (ORCPT ); Fri, 14 Feb 2014 03:17:30 -0500 Received: from ns.mm-sol.com ([37.157.136.199]:35489 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751745AbaBNIR2 (ORCPT ); Fri, 14 Feb 2014 03:17:28 -0500 Message-ID: <1392365765.12787.89.camel@iivanov-dev> Subject: Re: [PATCH] spi: core: Validate lenght of the transfers in message From: "Ivan T. Ivanov" To: Mark Brown Cc: Gerhard Sittig , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 14 Feb 2014 10:16:05 +0200 In-Reply-To: <20140214002627.GG28112@sirena.org.uk> References: <1392302806-17267-1-git-send-email-iivanov@mm-sol.com> <20140213212757.GM4524@book.gsilab.sittig.org> <20140214002627.GG28112@sirena.org.uk> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2014-02-14 at 00:26 +0000, Mark Brown wrote: > On Thu, Feb 13, 2014 at 10:27:57PM +0100, Gerhard Sittig wrote: > > On Thu, Feb 13, 2014 at 16:46 +0200, Ivan T. Ivanov wrote: > > > > SPI transfer lenght should be a power-of-two multiple > > > of eight bits. > > > Are you suggesting that an SPI transfer cannot consist of e.g. > > three bytes? This would be surprising, and certainly would be > > rather wrong an assumption. Am I missing/misunderstanding > > something? > > The check is supposed to be verifying that the transfer is a whole > number of the current SPI word size as I understand it (not actually > looked at the change yet but that's where it came from, factored out of > a driver). Yes. Comment is not correct. Is this better? "SPI transfer length should be multiple of SPI word size, where SPI word size should be power-of-two multiple" Regards, Ivan From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ivan T. Ivanov" Subject: Re: [PATCH] spi: core: Validate lenght of the transfers in message Date: Fri, 14 Feb 2014 10:16:05 +0200 Message-ID: <1392365765.12787.89.camel@iivanov-dev> References: <1392302806-17267-1-git-send-email-iivanov@mm-sol.com> <20140213212757.GM4524@book.gsilab.sittig.org> <20140214002627.GG28112@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Gerhard Sittig , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Return-path: In-Reply-To: <20140214002627.GG28112-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Fri, 2014-02-14 at 00:26 +0000, Mark Brown wrote: > On Thu, Feb 13, 2014 at 10:27:57PM +0100, Gerhard Sittig wrote: > > On Thu, Feb 13, 2014 at 16:46 +0200, Ivan T. Ivanov wrote: > > > > SPI transfer lenght should be a power-of-two multiple > > > of eight bits. > > > Are you suggesting that an SPI transfer cannot consist of e.g. > > three bytes? This would be surprising, and certainly would be > > rather wrong an assumption. Am I missing/misunderstanding > > something? > > The check is supposed to be verifying that the transfer is a whole > number of the current SPI word size as I understand it (not actually > looked at the change yet but that's where it came from, factored out of > a driver). Yes. Comment is not correct. Is this better? "SPI transfer length should be multiple of SPI word size, where SPI word size should be power-of-two multiple" Regards, Ivan -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html