From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: missing dependency on libxlu_disk_l.h Date: Tue, 18 Feb 2014 10:18:49 +0000 Message-ID: <1392718729.11080.13.camel@kazak.uk.xensource.com> References: <20140215221737.GA28254@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140215221737.GA28254@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering Cc: Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Sat, 2014-02-15 at 23:17 +0100, Olaf Hering wrote: Please remember to CC the maintainers of the code you are discussing. Ian J added. > I'm not sure if libxlu_disk_l.h is a generated file. It is, but we also check in the generated version, IIRC due to a bug in some versions of flex, but also partially for convenience to avoid the need for flex on all development systems. > But just once I saw > this failure below with automated build and make -j 16. This source tree > has the discard-enable patch, which changes tools/libxl/libxlu_disk_l.l. > As a result libxlu_disk_l.c is regenerated, see the flex call below. It might be a good idea to either also patch the generated files or to have the patch remove them, to avoid any possible confusion due to skew. > How should make become aware of the libxlu_disk_l.h dependency? I think it would probably need explicitly specifying like we do for the IDL generated files. What deleted that file though? > Olaf > > .... > [ 126s] /usr/bin/perl -w libxl_save_msgs_gen.pl _libxl_save_msgs_helper.h >_libxl_save_msgs_helper.h.new > [ 126s] python gentypes.py libxl_types.idl __libxl_types.h __libxl_types_json.h __libxl_types.c > [ 126s] python gentypes.py libxl_types_internal.idl __libxl_types_internal.h __libxl_types_internal_json.h __libxl_types_internal.c > [ 126s] if ! cmp -s _libxl_list.h.new _libxl_list.h; then mv -f _libxl_list.h.new _libxl_list.h; else rm -f _libxl_list.h.new; fi > [ 126s] /usr/bin/flex --header-file=libxlu_disk_l.h --outfile=libxlu_disk_l.c libxlu_disk_l.l > [ 126s] /usr/bin/perl -w libxl_save_msgs_gen.pl _libxl_save_msgs_callout.c >_libxl_save_msgs_callout.c.new > [ 126s] /usr/bin/perl -w libxl_save_msgs_gen.pl _libxl_save_msgs_helper.c >_libxl_save_msgs_helper.c.new > [ 126s] sed -e "s/\([^=]*\)=\(.*\)/#define \1 \2/g" _paths.h.tmp >_paths.h.2.tmp > [ 126s] rm -f _paths.h.tmp > -- > [ 126s] gcc -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs -D__XEN_TOOLS__ -MMD -MF .flexarray.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls -fmessage-length=0 -grecord-gcc-switches -fstack-protector -O2 -Wall -D_FORTIFY_SOURCE=2 -funwind-tables -fasynchronous-unwind-tables -Werror -Wno-format-zero-length -Wmissing-declarations -Wno-declaration-after-statement -Wformat-nonliteral -I. -fPIC -pthread -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/l ibxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/xenstore -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/control -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -Wshadow -include /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/config.h -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0- testing/tools/libxl/../../tools/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/xenstore -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/control -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -Wshadow -include /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/config.h -c -o flexarray.o flexarray.c > [ 126s] gcc -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs -D__XEN_TOOLS__ -MMD -MF .libxl.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls -fmessage-length=0 -grecord-gcc-switches -fstack-protector -O2 -Wall -D_FORTIFY_SOURCE=2 -funwind-tables -fasynchronous-unwind-tables -Werror -Wno-format-zero-length -Wmissing-declarations -Wno-declaration-after-statement -Wformat-nonliteral -I. -fPIC -pthread -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/xenstore -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/control -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -Wshadow -include /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/config.h -c -o libxl.o libxl.c > [ 126s] gcc -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs -D__XEN_TOOLS__ -MMD -MF .libxl_create.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls -fmessage-length=0 -grecord-gcc-switches -fstack-protector -O2 -Wall -D_FORTIFY_SOURCE=2 -funwind-tables -fasynchronous-unwind-tables -Werror -Wno-format-zero-length -Wmissing-declarations -Wno-declaration-after-statement -Wformat-nonliteral -I. -fPIC -pthread -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tool s/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/xenstore -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/control -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -Wshadow -include /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/config.h -c -o libxl_create.o libxl_create.c > [ 126s] gcc -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs -D__XEN_TOOLS__ -MMD -MF .libxl_dm.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls -fmessage-length=0 -grecord-gcc-switches -fstack-protector -O2 -Wall -D_FORTIFY_SOURCE=2 -funwind-tables -fasynchronous-unwind-tables -Werror -Wno-format-zero-length -Wmissing-declarations -Wno-declaration-after-statement -Wformat-nonliteral -I. -fPIC -pthread -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/li bxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/xenstore -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/control -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -Wshadow -include /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/config.h -c -o libxl_dm.o libxl_dm.c > [ 126s] libxlu_pci.c:3:27: fatal error: libxlu_disk_l.h: No such file or directory > [ 126s] #include "libxlu_disk_l.h" > [ 126s] ^ > [ 126s] compilation terminated. > [ 126s] /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/Rules.mk:89: recipe for target 'libxlu_pci.o' failed > [ 126s] make[3]: *** [libxlu_pci.o] Error 1 > [ 126s] make[3]: *** Waiting for unfinished jobs.... > [ 126s] libxlu_disk.c:3:27: fatal error: libxlu_disk_l.h: No such file or directory > [ 126s] #include "libxlu_disk_l.h" > [ 126s] ^ > [ 126s] compilation terminated. > [ 126s] /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/Rules.mk:89: recipe for target 'libxlu_disk.o' failed > [ 126s] make[3]: *** [libxlu_disk.o] Error 1 > .... > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel