From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WI9kB-0000k7-7u for qemu-devel@nongnu.org; Mon, 24 Feb 2014 23:35:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WI9k5-0005fv-1T for qemu-devel@nongnu.org; Mon, 24 Feb 2014 23:35:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4278) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WI9k4-0005fr-PU for qemu-devel@nongnu.org; Mon, 24 Feb 2014 23:35:40 -0500 From: Bandan Das Date: Mon, 24 Feb 2014 23:34:23 -0500 Message-Id: <1393302864-11348-2-git-send-email-bsd@redhat.com> In-Reply-To: <1393302864-11348-1-git-send-email-bsd@redhat.com> References: <1393302864-11348-1-git-send-email-bsd@redhat.com> Subject: [Qemu-devel] [PATCH 1/2 v3] qdev-monitor: set DeviceState opts before calling realize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alex Williamson , "Michael S. Tsirkin" , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Markus Armbruster Setting opts before the realize property is set allows the following patch to make decisions based on whether the user specified "rombar". This also avoids having to create a new tristate property especially for this purpose Signed-off-by: Bandan Das --- qdev-monitor.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index 3a7dc0d..6673e3c 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -548,16 +548,18 @@ DeviceState *qdev_device_add(QemuOpts *opts) OBJECT(dev), NULL); g_free(name); } + + dev->opts = opts; object_property_set_bool(OBJECT(dev), true, "realized", &err); if (err != NULL) { qerror_report_err(err); error_free(err); + dev->opts = NULL; object_unparent(OBJECT(dev)); object_unref(OBJECT(dev)); qerror_report(QERR_DEVICE_INIT_FAILED, driver); return NULL; } - dev->opts = opts; return dev; } -- 1.8.3.1