From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Williamson Subject: Re: [PATCH] ASoC: Intel: sst-acpi: Fix Oops in case of missing firmware Date: Tue, 25 Feb 2014 08:57:21 -0800 Message-ID: <1393347441.8300.82.camel@adam.happyassassin.net> References: <1393339067-10307-1-git-send-email-jarkko.nikula@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by alsa0.perex.cz (Postfix) with ESMTP id E283E265620 for ; Tue, 25 Feb 2014 17:57:30 +0100 (CET) In-Reply-To: <1393339067-10307-1-git-send-email-jarkko.nikula@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Jarkko Nikula Cc: Liam Girdwood , alsa-devel@alsa-project.org, Mark Brown , Mika Westerberg , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Tue, 2014-02-25 at 16:37 +0200, Jarkko Nikula wrote: > I swear I tested missing firmware in commit e5161d7987f1 ("ASoC: Intel: > sst-acpi: Request firmware before SST platform driver probing"). > > Unfortunately same wasn't done in commit 6dda27cbbd1d ("ASoC: Intel: > sst-acpi: Add support for multiple machine drivers per platform") which > will cause NULL pointer dereference in sst_acpi_fw_cb() when printing the > error since sst_acpi->mach is not set. > > Fix this obvious error by setting the sst_acpi->mach in sst_acpi_probe(). FWIW, I did test with the patch set from lrg's tree as of a couple days ago, and hit this crash. So I can confirm the bug for sure. I'll test the fix with a new kernel build in a couple of hours. -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net http://www.happyassassin.net